Skip to content

Merge pull request #67 from readyplayerme/fix/ACT-384 #298

Merge pull request #67 from readyplayerme/fix/ACT-384

Merge pull request #67 from readyplayerme/fix/ACT-384 #298

Triggered via push February 20, 2024 08:58
Status Success
Total duration 1m 37s
Artifacts

release.yml

on: push
Build, Deploy to GitHub pages, Release npm package
0s
Build, Deploy to GitHub pages, Release npm package
Fit to window
Zoom out
Zoom in

Annotations

12 warnings
Linting
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Linting: src/App/App.component.tsx#L27
Unexpected console statement
Linting: src/components/Avatar/Avatar.stories.tsx#L103
React Hook useEffect has unnecessary dependencies: 'initialValue' and 'maxValue'. Either exclude them or remove the dependency array. Outer scope values like 'initialValue' aren't valid dependencies because mutating them doesn't re-render the component
Linting: src/components/Avatar/Examples.stories.tsx#L163
The story should use PascalCase notation: environmentModel
Linting: src/components/Lights/Lights.component.tsx#L58
React Hook useEffect has missing dependencies: 'lightTarget', 'scene', 'targets.head', and 'targets.shoe'. Either include them or remove the dependency array
Linting: src/components/Models/BoundsModel/BoundsModel.container.tsx#L22
React Hook useCallback has a missing dependency: 'onLoaded'. Either include it or remove the dependency array
Linting: src/components/Models/BoundsModel/BoundsModel.container.tsx#L29
React Hook useMemo has an unnecessary dependency: 'modelSrc'. Either exclude it or remove the dependency array
Linting: src/components/Models/BoundsModel/BoundsModel.container.tsx#L36
React Hook useEffect has a missing dependency: 'bounds'. Either include it or remove the dependency array
Linting: src/components/Models/Model/Model.component.tsx#L95
React Hook useMemo has a missing dependency: 'scene'. Either include it or remove the dependency array
Linting: src/services/Models.service.tsx#L62
Unexpected console statement
Linting: src/services/Models.service.tsx#L357
React Hook useEffect has missing dependencies: 'headMesh.morphTargetDictionary' and 'selectedExpression'. Either include them or remove the dependency array
Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.