Skip to content

Commit

Permalink
metrics: Fix replay misses
Browse files Browse the repository at this point in the history
Previously, we were using a chunked replay metric in the
`DomainMetrics::inc_replay_misses` method, which is intended to count
the number of misses during a replay for a given domain. This commit
switches in the correct metric.

Release-Note-Core: Fixed an issue where the wrong metric was being
  emitted to count the number of misses during a replay.
Change-Id: I52476dd2b8f2089ebaa083b1ccaf4b38fa3623c1
Reviewed-on: https://gerrit.readyset.name/c/readyset/+/6848
Tested-by: Buildkite CI
Reviewed-by: Luke Osborne <luke@readyset.io>
  • Loading branch information
ethan-readyset committed Feb 5, 2024
1 parent 6c3809b commit 0d4d2ff
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion readyset-dataflow/src/domain/domain_metrics.rs
Expand Up @@ -307,7 +307,7 @@ impl DomainMetrics {
ctr.increment(n as u64);
} else {
let ctr = register_counter!(
recorded::DOMAIN_TOTAL_CHUNKED_REPLAY_START_TIME,
recorded::DOMAIN_REPLAY_MISSES,
"domain" => self.index.clone(),
"shard" => self.shard.clone(),
"miss_in" => miss_in.id().to_string(),
Expand Down

0 comments on commit 0d4d2ff

Please sign in to comment.