readyset-psql: Un-ignore passing fallback test #420
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was fixed some time ago when we fixed #106 by reverting the following commit: 670413429 (replicators: Skip catch up if ReadySet did not snapshot any table., 2023-03-30) in this revert commit here: 0e8746ac3 (Revert "replicators: Skip catch up if ReadySet did not snapshot any table.", 2023-07-10) But I neglected to also enable the test after the revert was merged. Since the test now passes, I'm removing the ignore. Refs: #106 Refs: REA-2664 Refs: REA-2437 Change-Id: I2ff061f1deeaab65c862c5140f497c60e02fb9b2
readysetbot
force-pushed
the
I2ff061f1deeaab65c862c5140f497c60e02fb9b2
branch
from
01530df
to
4fb0242
Compare
nickelization
changed the base branch from
main
to
Ida027758524a89764a3bfa434bbf2def74a214b0
|
Merged as 1083bd8bded18411020387d8f7075e955f8e533a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was fixed some time ago when we fixed #106 by reverting the
following commit:
670413429 (replicators: Skip catch up if ReadySet did not snapshot any table., 2023-03-30)
in this revert commit here:
0e8746ac3 (Revert "replicators: Skip catch up if ReadySet did not snapshot any table.", 2023-07-10)
But I neglected to also enable the test after the revert was merged.
Since the test now passes, I'm removing the ignore.
Refs: #106
Refs: REA-2664
Refs: REA-2437