readyset-data: Add format field to PassThrough struct #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the new field, but doesn't do anything interesting with it yet. The plan is to use this to support passthrough of text-formatted parameters of unsupported types when we proxy queries, but for now we just hardcode the format to Binary everywhere so as to maintain the existing behavior. Followup commits will add support for encoding parameters as text in proxied queries when the format flag is set to do so, and once that's done we can actually set the format flag to Text and use the PassThrough type in the `get_text_value` function in the psql-srv decoder. Refs: #266 Refs: REA-3183 Change-Id: I3419ba96e1435b30b08f2bd154832da19afd2d59
|
Merged as 6c4dde0466f787061741a9a965d34d8f3ba55e5d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the new field, but doesn't do anything interesting with
it yet. The plan is to use this to support passthrough of text-formatted
parameters of unsupported types when we proxy queries, but for now we
just hardcode the format to Binary everywhere so as to maintain the
existing behavior.
Followup commits will add support for encoding parameters as text in
proxied queries when the format flag is set to do so, and once that's
done we can actually set the format flag to Text and use the PassThrough
type in the
get_text_valuefunction in the psql-srv decoder.Refs: #266
Refs: REA-3183