Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BD-15: Integrating SQL-migrate #22

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from
Open

BD-15: Integrating SQL-migrate #22

wants to merge 15 commits into from

Conversation

abinav-07
Copy link

@abinav-07 abinav-07 commented Jan 30, 2023

Jira: https://readytowork.atlassian.net/browse/BD-15
Done:

  • Used MemoryMigrationSource to create custom migration files.
  • Checked empty migration files using Sql-migrate "Up" attribute.

To-Do:

  • Write custom script to generate custom migration files with Id, CreatedAt and DeletedAt columns.

@sumitsapkota75 dai, Couldn't create custom script using windows since SQL-migrate is not working, but works in docker.

@abinav-07 abinav-07 self-assigned this Jan 30, 2023
RUN set -x \
&& apk add --no-cache git \
&& git clone --branch "v${VERSION}" --depth 1 --single-branch https://github.com/golang-migrate/migrate /tmp/go-migrate
RUN go install github.com/rubenv/sql-migrate/...@latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use go install in one line to install multiple go packages

Copy link
Contributor

@neekesh neekesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PLease resolve the conflict

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants