Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning when building with v1.9.660 of the ClojureScript compiler #304

Closed
khellang opened this issue Jun 28, 2017 · 1 comment
Closed

Warning when building with v1.9.660 of the ClojureScript compiler #304

khellang opened this issue Jun 28, 2017 · 1 comment

Comments

@khellang
Copy link

The ClojureScript team recently released v1.9.660 with a new warning for variadic signatures in protocol methods:

NOTE: that this release introduces a new warning for incorrect code which employs variadic signatures in protocol method implementations. Such code will continue to work with this release. Be sure to update any code or libraries that make use of this construct so that protocol implementations match some existing signature.

This results in a compiler warning when building our application using Reagent:

WARNING: Protocol IFn implements method -invoke with variadic signature (&) at line 61 ..\target\cljsbuild-compiler-1\reagent\impl\util.cljs

See https://clojurescript.org/news/2017-06-27-faster-compilation-runtime-and-spec-caching-fixes

@khellang
Copy link
Author

Oh, sorry. Didn't see #303. Thanks for fixing it so quickly 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant