Fix partial-ifn with latest Cljs #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old implementation incorrectly used variadic arity for -invoke implementation. Variadic artities for protocols are not supported by Cljs. The old code as worked by luck but was broken by a recent change: https://dev.clojure.org/jira/browse/CLJS-2099 New implementation properly implements all the artities for -invoke. New implementation creates the partial fn in a constructor function, so -invoke code doesn't need to do that. New implementation also implements Fn.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old implementation incorrectly used variadic arity for -invoke
implementation. Variadic artities for protocols are not supported by
Cljs. The old code as worked by luck but
was broken by a recent changenow gives a warning:https://dev.clojure.org/jira/browse/CLJS-2099
New implementation properly implements all the artities for -invoke. New
implementation creates the partial fn in a constructor function, so -invoke
code doesn't need to do that. New implementation also implements Fn.