Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find better name for "Compiler" object #495

Closed
Deraen opened this issue Apr 27, 2020 · 3 comments
Closed

Find better name for "Compiler" object #495

Deraen opened this issue Apr 27, 2020 · 3 comments

Comments

@Deraen
Copy link
Member

Deraen commented Apr 27, 2020

In Reagent, the Hiccup-style markup is converted to React element calls in runtime, so compiler is not the best name to describe this. But I don't like Interpreter either as name for this. "Options" also feels confusing, because the object really contains a few methods and maybe some internal state (cache).

  • The name shouldn't be to connected to the implementation, runtime vs. macro compilation time
  • Shouldn't be confusing with React or ClojureScript terms
@victorb
Copy link

victorb commented May 5, 2020

Calling out the most obvious first: converter, adapter or translator. Very overloaded terms in programming though, so might be best to avoid.

Otherwise, more unique but still descriptive would be something like elementifier. I guess something that could be very explicit about it's meaning would be markup->elements / markup->elements-fn or similar.

@davidpham87
Copy link

Some candidate popping up in my mind: hiccup->elements, hiccup->elems.

@jeroenvandijk
Copy link

compiler sounds like a good name to me

@Deraen Deraen closed this as completed Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants