Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix components not rendering id prop #520

Merged
merged 2 commits into from Dec 18, 2019

Conversation

diegohaz
Copy link
Member

@diegohaz diegohaz commented Dec 18, 2019

Closes #518

This PR fixes regressions introduced by #492 and #494, which made some components ignore the id prop.

@namjul Do you know if there are other components with the same issue?

Does this PR introduce a breaking change?

No

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 33ecd00:

Sandbox Source
inspiring-moon-p1chg Configuration
priceless-wilbur-ovpjx Issue #518

@codecov
Copy link

codecov bot commented Dec 18, 2019

Codecov Report

Merging #520 into master will increase coverage by <.01%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #520      +/-   ##
=========================================
+ Coverage    96.4%   96.4%   +<.01%     
=========================================
  Files          99      99              
  Lines        1500    1504       +4     
  Branches      476     480       +4     
=========================================
+ Hits         1446    1450       +4     
  Misses         54      54
Impacted Files Coverage Δ
packages/reakit/src/Id/IdGroup.tsx 100% <100%> (ø) ⬆️
packages/reakit/src/Id/Id.tsx 100% <100%> (ø) ⬆️
packages/reakit/src/Rover/Rover.ts 94.11% <100%> (ø) ⬆️
packages/reakit/src/Tab/__utils.ts 100% <100%> (ø) ⬆️
packages/reakit/src/Tab/Tab.ts 92.85% <83.33%> (+0.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5e1e8f...ff98fee. Read the comment docs.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ff98fee:

Sandbox Source
eloquent-platform-d7pz0 Configuration
wonderful-bush-mpdrh Issue #518

@ariakit-bot
Copy link

Deploy preview for reakit ready!

Built with commit ff98fee

https://deploy-preview-520--reakit.netlify.com

@diegohaz diegohaz merged commit 866db9d into master Dec 18, 2019
@diegohaz diegohaz deleted the fix/components-not-rendering-id-prop branch December 18, 2019 14:07
@siggirh
Copy link

siggirh commented Jan 5, 2020

With this change you can no longer use zero as a stopId since !stopId will always be false. :)

EDIT: Nm, didnt know the stopId had to be a string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some components don't render the passed id prop
3 participants