fix: Prevent clicks when pressing Enter/Space with meta key on non-native Tabbable
#534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c68a5e2:
|
Codecov Report
@@ Coverage Diff @@
## master #534 +/- ##
==========================================
- Coverage 96.39% 96.36% -0.03%
==========================================
Files 99 99
Lines 1496 1515 +19
Branches 475 481 +6
==========================================
+ Hits 1442 1460 +18
- Misses 54 55 +1
Continue to review full report at Codecov.
|
|
Deploy preview for reakit ready! Built with commit c68a5e2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When clicking on a non-native
Tabbablecomponent (e.g.<Tabbable as="div" />) by pressing Enter or Space in conjunction with the meta key (e.g. ⌘), the button should not be activated.Does this PR introduce a breaking change?
No