Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix MenuButton not receiving focus after Menu closes #692

Merged
merged 2 commits into from
Jul 18, 2020

Conversation

diegohaz
Copy link
Member

@diegohaz diegohaz commented Jul 14, 2020

This issue exists on master:

  1. Open https://reakit.io/storybook/?path=/story/menu--menu-with-dialog
  2. Focus menu button
  3. Press ArrowUp
  4. Press Escape

Focus will not return to the menu button. Now do the same on https://deploy-preview-692--reakit.netlify.app/storybook/?path=/story/menu--menu-with-dialog (this PR).

Does this PR introduce a breaking change?

No.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 14, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6646cc6:

Sandbox Source
Reakit Configuration

@ariakit-bot
Copy link

ariakit-bot commented Jul 14, 2020

Deploy preview for reakit ready!

Built with commit 6646cc6

https://deploy-preview-692--reakit.netlify.app

@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2020

Size Change: 0 B

Total Size: 250 kB

ℹ️ View Unchanged
Filename Size Change
packages/reakit-playground/dist/reakit-playground.min.js 186 kB 0 B
packages/reakit-system-bootstrap/dist/reakit-system-bootstrap.min.js 19.2 kB 0 B
packages/reakit-system-palette/dist/reakit-system-palette.min.js 8.84 kB 0 B
packages/reakit-system/dist/reakit-system.min.js 2.21 kB 0 B
packages/reakit-utils/dist/reakit-utils.min.js 3.16 kB 0 B
packages/reakit/dist/reakit.min.js 31.1 kB 0 B

compressed-size-action

@codecov
Copy link

codecov bot commented Jul 14, 2020

Codecov Report

Merging #692 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #692   +/-   ##
=======================================
  Coverage   95.58%   95.58%           
=======================================
  Files         151      151           
  Lines        2788     2788           
  Branches      727      727           
=======================================
  Hits         2665     2665           
  Misses        123      123           
Impacted Files Coverage Δ
packages/reakit/src/Menu/MenuButton.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ae0da7...6646cc6. Read the comment docs.

@diegohaz diegohaz merged commit e649f20 into master Jul 18, 2020
@diegohaz diegohaz deleted the fix/menu-button-return-focus-after-arrow-up branch July 18, 2020 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants