Skip to content

Commit

Permalink
Merge pull request #3 from real-digital/phpunit8
Browse files Browse the repository at this point in the history
Provide compatibility with PHPUnit 8
  • Loading branch information
radarlog committed Mar 13, 2019
2 parents dfb18cc + 2872ec1 commit c7bf673
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 12 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,17 @@
[1.0.0]: https://github.com/real-digital/gtin-validator/commits/1.0.0
[1.0.1]: https://github.com/real-digital/gtin-validator/commits/1.0.1
[1.0.2]: https://github.com/real-digital/gtin-validator/commits/1.0.2
[1.1.0]: https://github.com/real-digital/gtin-validator/commits/1.1.0

# Changelog

All notable changes to this project will be listed in this file.

## [1.1.0] - 2019-03-12

- Provide compatibility with PHPUnit 8
- Run tests against PHP 7.3

## [1.0.2] - 2018-10-16

- Update brand links
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"php": "^7.1"
},
"require-dev": {
"phpunit/phpunit": "^7.3",
"phpunit/phpunit": "^7.3 || ^8.0",
"php-coveralls/php-coveralls": "^2.1"
},
"autoload": {
Expand Down
1 change: 1 addition & 0 deletions phpunit.xml.dist
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="http://schema.phpunit.de/7.3/phpunit.xsd"
bootstrap="vendor/autoload.php"
cacheResultFile="build/phpunit.cache"
colors="true"
executionOrder="random"
>
Expand Down
14 changes: 3 additions & 11 deletions tests/Gtin/Specification/DigitsTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -26,18 +26,13 @@ public function digitsProvider(): array
{
return [
['1', true],
[123, true],
[42, true],
[012, true],
['123', true],
['42', true],
['012', true],
['0', true],
[0, true],
[00000000000000000000000, true],
['0000000000000000000000', true],
[0xff, true],
[0b11, true],
['-1', false],
[-100, false],
['-100', false],
['25-4', false],
['', false],
[' ', false],
Expand All @@ -53,9 +48,6 @@ public function digitsProvider(): array

/**
* @dataProvider digitsProvider
*
* FYI: Strict type declarations not enforced for Reflection API invocation
* @link https://externals.io/message/100851
*/
public function testIsSatisfied(string $value, bool $isSatisfied)
{
Expand Down

0 comments on commit c7bf673

Please sign in to comment.