putDouble / getDouble

[danny-pav]

aeron/aeron-client/src/main/cpp/concurrent/AtomicBuffer.h

Line 35 in 4bb183d

class AtomicBuffer

there is a putInt## / getInt## for 8, 16, 32, 64 but no putDouble / getDouble

[mjpt777]

We have not needed these methods ourselves. Feel free to send a PR if you need them.

[danny-pav]

Martin- I had tried to make changes via PR before for some of the simpler issues (1119 or 1120 -- can't remember) and was unable to. I will try again and let you know what error I was getting. I feel like it was a permissioning issue of some sort. Additionally, is there a naming standard for branches for the PR? Thanks, Dan

…

________________________________ From: Martin Thompson <notifications@github.com> Sent: Wednesday, January 13, 2021 10:18 AM To: real-logic/aeron <aeron@noreply.github.com> Cc: danny-pav <danny_pav@hotmail.com>; Author <author@noreply.github.com> Subject: Re: [real-logic/aeron] putDouble / getDouble (#1121) We have not needed these methods ourselves. Feel free to send a PR if you need them. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#1121 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/APIQWFHUN3HWQHNSAD4TAGDSZW2SZANCNFSM4WA6D34Q>.

[mikeb01]

There are no naming conventions for branches, but in order to raise a PR you need to fork your own copy of the repo and create the branch there.

[danny-pav]

That's the problem. I did not create a fork. Simply made a clone, created a branch, then pushed to branch of same name. (this is the workflow i use professionally)

…

________________________________ From: Michael Barker <notifications@github.com> Sent: Thursday, January 14, 2021 1:35 AM To: real-logic/aeron <aeron@noreply.github.com> Cc: danny-pav <danny_pav@hotmail.com>; Author <author@noreply.github.com> Subject: Re: [real-logic/aeron] putDouble / getDouble (#1121) There are no naming conventions for branches, but in order to raise a PR you need to fork your own copy of the repo and create the branch there. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#1121 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/APIQWFHVEFF3DY7KANBZZBLSZ2GCVANCNFSM4WA6D34Q>.

[mjpt777]

Closing due to no further activity.