Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C] Restore dynamic logging events. #1097

Merged
merged 2 commits into from Dec 3, 2020
Merged

[C] Restore dynamic logging events. #1097

merged 2 commits into from Dec 3, 2020

Conversation

vyazelenko
Copy link
Contributor

  • Restore dynamic event logging.
  • Add checks if dynamic event logging is enabled.
  • Use array of structs to keep track of event descriptors.

@mjpt777
Copy link
Contributor

mjpt777 commented Dec 3, 2020

I think the arrays of structs is more readable.

@vyazelenko
Copy link
Contributor Author

@mjpt777 Any blockers for this PR to be merged?

@mjpt777
Copy link
Contributor

mjpt777 commented Dec 3, 2020

Not from me. I was waiting for the others to feedback before merging since they had the concerns.

@tmontgomery
Copy link
Contributor

LGTM

@vyazelenko vyazelenko merged commit e5a491f into real-logic:master Dec 3, 2020
@vyazelenko vyazelenko deleted the c-agent-logging-dynamic-events branch December 3, 2020 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vyazelenko @mjpt777 @tmontgomery