[Java] Introduce SnapshotDurationTracker #1532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliquinox
commented
Nov 14, 2023
aeron-cluster/src/main/java/io/aeron/cluster/service/SnapshotDurationTracker.java
Outdated
Show resolved
Hide resolved
eliquinox
force-pushed
the
consensus-module-snapshot-duration-counters
branch
from
c8e8d14
to
88c6199
Compare
mjpt777
reviewed
Nov 16, 2023
aeron-system-tests/src/test/java/io/aeron/cluster/ClusterTest.java
Outdated
Show resolved
Hide resolved
|
In general LGTM. |
eliquinox
force-pushed
the
consensus-module-snapshot-duration-counters
branch
2 times, most recently
from
99e7479
to
75b27bd
Compare
mjpt777
reviewed
Nov 16, 2023
aeron-cluster/src/main/java/io/aeron/cluster/service/SnapshotDurationTracker.java
Outdated
Show resolved
Hide resolved
mjpt777
reviewed
Nov 16, 2023
aeron-cluster/src/main/java/io/aeron/cluster/service/SnapshotDurationTracker.java
Outdated
Show resolved
Hide resolved
eliquinox
force-pushed
the
consensus-module-snapshot-duration-counters
branch
from
75b27bd
to
4f56451
Compare
|
@eliquinox Why not use a plain DutyCycleStallTracker which we is used in all other places? |
vyazelenko
requested changes
Nov 16, 2023
aeron-cluster/src/main/java/io/aeron/cluster/ConsensusModule.java
Outdated
Show resolved
Hide resolved
aeron-cluster/src/main/java/io/aeron/cluster/ConsensusModule.java
Outdated
Show resolved
Hide resolved
aeron-cluster/src/main/java/io/aeron/cluster/ConsensusModule.java
Outdated
Show resolved
Hide resolved
aeron-cluster/src/main/java/io/aeron/cluster/ConsensusModuleAgent.java
Outdated
Show resolved
Hide resolved
vyazelenko
requested changes
Nov 16, 2023
aeron-cluster/src/main/java/io/aeron/cluster/ConsensusModule.java
Outdated
Show resolved
Hide resolved
eliquinox
force-pushed
the
consensus-module-snapshot-duration-counters
branch
from
4f56451
to
df92eba
Compare
eliquinox
force-pushed
the
consensus-module-snapshot-duration-counters
branch
from
df92eba
to
3721d31
Compare
vyazelenko
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a set of counters that enable monitoring of snapshot duration within Cluster's Consensus Module:
AeronCounters#CLUSTER_CONSENSUS_MODULE_MAX_SNAPSHOT_DURATION_TYPE_IDto track maximum snapshot duration.AeronCounters#CLUSTER_CONSENSUS_MODULE_SNAPSHOT_DURATION_THRESHOLD_EXCEEDED_TYPE_IDto track number of times a predefined threshold value (see below) has been exceeded.Threshold value can be set via
aeron.cluster.consensus.module.snapshot.thresholdproperty or viaio.aeron.cluster.ConsensusModule.Context#snapshotDurationThresholdNs(long).