Annotations to support config/counters documentation/validation #1593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
aeron-annotations/src/main/java/io/aeron/config/docgen/GenerateConfigDocTask.java
Fixed
Show fixed
Hide fixed
aeron-annotations/src/main/java/io/aeron/counter/validation/Validator.java
Fixed
Show fixed
Hide fixed
nbradac
changed the title
aeron-annotations/src/main/java/io/aeron/config/docgen/GenerateConfigDocTask.java
Fixed
Show fixed
Hide fixed
aeron-annotations/src/main/java/io/aeron/config/docgen/ConfigDocGenerator.java
Fixed
Show fixed
Hide fixed
nbradac
commented
May 9, 2024
aeron-annotations/src/main/java/io/aeron/config/ConfigInfo.java
Outdated
Show resolved
Hide resolved
aeron-annotations/src/main/java/io/aeron/config/validation/Validator.java
Fixed
Show fixed
Hide fixed
aeron-annotations/src/main/java/io/aeron/config/validation/Validator.java
Fixed
Show fixed
Hide fixed
mikeb01
reviewed
May 20, 2024
aeron-annotations/src/main/java/io/aeron/config/validation/Validation.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very much a work in progress. Much of this is still pretty rough. But I think the general approach is more or less validated (it works at least...). Biggest/current open questions (for me) are around the right way to get this integrated correctly into the build.
There's now a task that validates the aeron counters between java and C