Add unicast semantics to RetransmitHandler #1603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbradac
changed the title
nbradac
changed the title
…ciated test fixtures
mikeb01
changed the title
mikeb01
reviewed
May 26, 2024
aeron-driver/src/main/java/io/aeron/driver/DriverConductor.java
Outdated
Show resolved
Hide resolved
mikeb01
reviewed
May 26, 2024
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RetransmitHandler now supports unicast semantics where it only keeps track of (at most) one outstanding NAK, and it immediately replaces old NAKs with new NAKs, on the assumption that a new NAK means the receiver has moved past the previous gap (i.e. the previous NAK 'worked' and the RX was received).
To test this, a new 'MultiGapLossGenerator' was created that will introduce loss across a series of regularly spaced intervals to force the condition where more than the max outstanding retransmit actions are sent in a short period of time. The previous (i.e. 'multicast') retransmit handler logic would just drop subsequent NAKs, requiring some NAKs be resent.