Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error Frames and User Image Invalidation #1604

Open
wants to merge 42 commits into
base: master
Choose a base branch
from
Open

Error Frames and User Image Invalidation #1604

wants to merge 42 commits into from

Conversation

mikeb01
Copy link
Contributor

@mikeb01 mikeb01 commented May 24, 2024

  • Support the ability to allow a user to invalidate an image within a subscription.

@mikeb01 mikeb01 changed the title User Image Invalidation Error Frames and User Image Invalidation Jun 13, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 24, 2024
View reviewed changes
aeron-system-tests/src/test/java/io/aeron/ImageInvalidationTest.java Outdated

public void onPublicationError(final PublicationErrorFrame errorFrame)
{
errorFrameQueue.offer(errorFrame.clone());

Check notice

Code scanning / CodeQL

Ignored error status of call Note

Method onPublicationError ignores exceptional return value of OneToOneConcurrentArrayQueue.offer.
@mikeb01
[Java] Use private method to update state in PublicationImage.
bae260c
@mikeb01
[Java] Add basic test and command to invalidate and image from user c…
f5448ff 
…ode. Prevent new data being inserted into an invalidated image. Add logging.
@mikeb01
[Java] Set image invalidation test as a slow test. Early exit of imag…
e732b9d 
…e is found during invalidation on the receiver.
@mikeb01
[Java] Start adding ErrorFlyweight.
dc6cf3e
@mikeb01
[Java] Pass invalidation reason through to the source publication and…
7813bce 
… have it disconnect. Allow receiver side image to linger to prevent immediately recreation of the image. Treat errors received by the NetworkPublication to behaviour like end of stream messages.
@mikeb01
[C] Start adding invalidate image information.
0193edf
@mikeb01
[C] Invalidate image on the receiver.
7ff33e5
@mikeb01
[Java/C] Fix CodeQL errors.
18d7b1d
@mikeb01
[C] Add support for send/receiving error frames and update flow contr…
3a604e8 
…ol and liveness.
@mikeb01
[C] Tighten stack allocation of buffer to work better with MSVC. Don'…
ecb7b3c 
…t send max frame size each time.
@mikeb01
[Java] New system counter to track number of error messages received.…
371e7cb 
… Check that we don't spam out error messages too quickly. Reset timestamp of last SM sent by the publication image when sending errors.
@mikeb01
[C] New system counter to track number of error messages received. Ch…
49c00d9 
…eck that we don't spam out error messages too quickly. Reset timestamp of last SM sent by the publication image when sending errors.
@mikeb01
[Java] Add additional tests for EOS and errors for MDC publications.
544e582
@mikeb01
[Java] Limit the length of the invalidation reason.
e406124
@mikeb01
[C] Limit reason length for image invalidation.
6194a2b
@mikeb01
[Java] Allow test to run on C media driver.
d018058
@mikeb01
[C/Java] Rename Error Messages to Error Frames.
8d64285
@mikeb01
[Java] Log errors when error frames are received.
da942d7
@mikeb01
[C] Log errors when error frames are received.
14b8ff7
@mikeb01
[Java] Enable test for C driver.
3cfc446
@mikeb01
[Java] Checkstyle.
2f99c50
@mikeb01
[C] Use C++ compliant flexible array member.
838d058
@mikeb01
[C] Handle flexible array members in MSVC.
8f4fabe
@mikeb01
[C] Use flexible array member correctly in more places for reason tex…
df57493 
…t on invalidate image.
@mikeb01
[Java] First pass at surfacing error frames to the client.
80399b6
@mikeb01
[C] Send publication error frames to the client.
dbdc70b
@mikeb01
[Java] Enable test for C driver.
989f9c5
@mikeb01
[Java] Only report publication error frame to client that has the pub…
60639b9 
…lication registered.
@mikeb01
[Java] Start encapsulating all fields relating to an error frame in a…
4d077e8 
…n object to be reported to the caller.
@mikeb01
[Java] Add additional parameters including source address of the erro…
4f16380 
…r frame.
@mikeb01
[Java] Disable test for IPv6.
87a7ee4
@mikeb01
[C] Add additional parameters to user visible error frame.
b50908a
@mikeb01
[C] Use ntohs instead of betoh16 (fix Mac).
ad01260
@mikeb01
[Java] Allow test to run always if the parameter is an IPv4 address.
1bfb129
@mikeb01
[Java] Naming and consistency updates.
6bf49d6
@mikeb01
[C] Fix compile error.
23e8a77
@mikeb01
[Java] Ensure that other clients with the same publication see the er…
1e216c4 
…ror frames.
@mikeb01
[Java] Use "reject" instead of "invalidate" for marking images for er…
c0d1cbe 
…rors.
@mikeb01
[Java] Javadoc.
df11346
@mikeb01
[Java] Remove last utf-8 encoding for error frames.
31e47bb
@mikeb01
[Java] Add error frames sent counter.
283400f
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 23, 2024
View reviewed changes
aeron-system-tests/src/test/java/io/aeron/RejectImageTest.java

public void onPublicationError(final PublicationErrorFrame errorFrame)
{
errorFrameQueue.offer(errorFrame.clone());

Check notice

Code scanning / CodeQL

Ignored error status of call Note

Method onPublicationError ignores exceptional return value of OneToOneConcurrentArrayQueue.offer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyazelenko vyazelenko vyazelenko left review comments

@mjpt777 mjpt777 mjpt777 left review comments

@wojciech-adaptive wojciech-adaptive wojciech-adaptive left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mikeb01 @vyazelenko @mjpt777 @wojciech-adaptive