Allows Catalog to be constructed over a directory where old recordings have been deleted #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This shows a change in behaviour where previously the Catalog could be constructed over directories where old recordings had been deleted.
…is passed is missing old recordings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Previously, we were able to start a consensus module over a directory where old recordings had been deleted; however, upon upgrading to v1.9.0 this was no longer possible.
This change adds back the aforementioned behaviour.
Changes
Inside
Catalog.refreshAndFixDescriptor(...)it determines the maximum "segment index" for a givenrecordingIdby looking at the file segments inside the archive directory. Previously it looked at all segment files. Now it just looks at the segment files that are for therecordingId.