Prevent creating multiple Clients or Media Drivers with the same cont… #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ext. Allowing it with clients cause a SEGV, instead now will throw IllegalStateException.
mjpt777
added a commit
that referenced
this pull request
May 12, 2019
…e on solution provided in PR #666, increase minor version as a result of change.
|
I notice that you moved the implementation inside of conclude. This is what I had originally, but I found that this implementation still segfaults as the the |
|
Good point. Maybe a different exception type that does not result in close being called. |
mjpt777
added a commit
that referenced
this pull request
May 12, 2019
…ound closing contexts as follow up to PR #666.
|
I'll have a look today. |
|
I pushed a change that does this. |
|
Looks good. Added another small PR that includes the unit tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ext. Allowing it with clients cause a SEGV, instead now will throw IllegalStateException. This has tripped me up twice now.