Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raise interrupted flag if InterruptedException caught in AgentRunner#close #112

Merged
merged 1 commit into from
Nov 10, 2017

Conversation

zyulyaev
Copy link

No description provided.

@zyulyaev
Copy link
Author

By the way, is interrupt flag cleared here by purpose?

@mjpt777 mjpt777 merged commit 7b933a8 into real-logic:master Nov 10, 2017
@mjpt777
Copy link
Contributor

mjpt777 commented Nov 10, 2017

It has been dealt with so cleared. I don't have a strong feeling either way as the agent thread is typically not used again.

@mjpt777
Copy link
Contributor

mjpt777 commented Nov 10, 2017

I suppose if something in the Agent.onClose() wants to check the flag then best leave it set.

@zyulyaev
Copy link
Author

Yes, for AgentRunner I agree that it is not that important. But it is for AgentInvoker, which does the same thing: line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants