Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow null values #154

Merged
merged 2 commits into from
Aug 16, 2018
Merged

Allow null values #154

merged 2 commits into from
Aug 16, 2018

Conversation

snazy
Copy link
Contributor

@snazy snazy commented Aug 16, 2018

This is a variation of #153, that adds the nullability of values to Object2ObjectHashMap, Int2ObjectHashMap + Long2ObjectHashMap. It's basically identical to the other PR, except that the nullability of the map values is optional via xyz2NullableObjectHashMap. BiInt2ObjectHashMap although allows null values.

Note: this PR does not include the fix for Object2ObjectHashMap.AbstractIterator.remove(), because it's not implicitly required for this variant of #153.

@snazy
Copy link
Contributor Author

snazy commented Aug 16, 2018

@mjpt777 sorry, I forgot to add the new tests to ConformanceTestsSuite. On it.

@snazy
Copy link
Contributor Author

snazy commented Aug 16, 2018

Pushed the fix

@mjpt777 mjpt777 merged commit c7db581 into real-logic:master Aug 16, 2018
@snazy snazy deleted the allow-null-values branch August 16, 2018 14:39
mjpt777 added a commit that referenced this pull request Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants