Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot override default archive control response channel in FixArchivePrinter #492

Closed
irisliu88 opened this issue Sep 15, 2023 · 0 comments
Closed

Cannot override default archive control response channel in FixArchivePrinter #492

irisliu88 opened this issue Sep 15, 2023 · 0 comments

Comments

@irisliu88
Copy link

irisliu88 commented Sep 15, 2023 •
edited
Loading

This commit makes it so that we cannot override the archive control channel with a system property This issue was previously referenced in this closed issue.

I think it'd be best if we didn't default the channel in FixArchiveScanner. And if the default still feels necessary, add it within AeronArchive configuration similar to CONTROL_RESPONSE_STREAM_ID_DEFAULT.
irisliu88 added a commit to irisliu88/artio that referenced this issue Sep 15, 2023
@irisliu88
fixes issue real-logic#492
1fe7da3
@irisliu88 irisliu88 changed the title Cannot override default archive control channel in FixArchivePrinter Cannot override default archive control response channel in FixArchivePrinter Sep 15, 2023
pcdv pushed a commit to pcdv/artio that referenced this issue Apr 5, 2024
@wojciech-adaptive @pcdv
improve FixArchive{Printer,Scanner} default settings (fixes real-logi…
932ebcf 
…c#468, fixes real-logic#492, closes real-logic#493)

In typical cases they should not require any archive settings, but if
any are required, then all should be overridable using system properties.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@irisliu88