Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deliver sbe.h via publicly available versioned SBE artifacts #540

Closed
vontikov opened this issue Feb 23, 2018 · 2 comments
Closed

Deliver sbe.h via publicly available versioned SBE artifacts #540

vontikov opened this issue Feb 23, 2018 · 2 comments

Comments

@vontikov
Copy link

Please pack sbe.h and license information into sbe-all.jar.
This would allow delivery of generated CPP codecs together with the SBE header they depend on, when the SBE Tool is used as a part of a Gradle project for example, without necessity of having SBE local repository during the build: sbe.h and license will be extracted directly from the jar.
This would also guarantee that the exact sbe.h version is used with the codecs.

@tmontgomery
Copy link
Contributor

Sounds good to me. Adding sbe.h and license to resources would be fine. Also, I would like it if sbe.h was generated for each codec instead of being a central one that had to be managed.

@mjpt777
Copy link
Contributor

mjpt777 commented Feb 24, 2018

I think also makes sense to add the C++ OTF code.

mjpt777 added a commit that referenced this issue Feb 25, 2018
@mjpt777 mjpt777 closed this as completed Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants