New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Java] toString() shouldn't disturb repeating groups #890
Comments
spoerri
added a commit
to spoerri/simple-binary-encoding
that referenced
this issue
Mar 4, 2022
mjpt777
pushed a commit
that referenced
this issue
Mar 7, 2022
Is this fix merged to master? |
It looks like it's either partially merged or partially rolled back :)
Above is missing, below is present in
|
@krisso-rtb If you think there is a remaining problem then please create a new issue with a test that demonstrates it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Calling
toString()
in the middle of decoding a repeating group breaks the decoding of that group. For example, subsequent entries are skipped:Only the first member of the repeating group will be handled.
The fix should be pretty simple: generate code into the
appendTo
method to save and restoreindex
andoffset
when handling each group, similar to how it already saves and restoreslimit
.The text was updated successfully, but these errors were encountered: