Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java] Invalid code generated for newly added string field #574

Merged
merged 1 commit into from
Jul 19, 2018
Merged

[Java] Invalid code generated for newly added string field #574

merged 1 commit into from
Jul 19, 2018

Commits on Jul 19, 2018

  1. [Java] Invalid code generated for newly added string field 

    If a schema is extended to include a new string field (fixed or variable), the newly generated decoder code not compile due to an error for deserialising the string using appendable; if the "sinceVersion" and "actingVersion" don't line up it tries to return a string on a void method. This commit changes the generated code to just call "return;"
    @tom-smalls
    tom-smalls committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    f44972c View commit details
    Browse the repository at this point in the history