Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about the controller used for diffusion policy #8

Closed
wkwan7 opened this issue Jun 1, 2023 · 2 comments
Closed

Question about the controller used for diffusion policy #8

wkwan7 opened this issue Jun 1, 2023 · 2 comments

Comments

@wkwan7
Copy link

wkwan7 commented Jun 1, 2023

Hi,

Thank you for your fantastic work and beautiful code! As described in the paper, you use position control instead of velocity control on the robomimic tasks for diffusion policy. However, I didn't find the corresponding changes to the robomimic environment controller in the code, except for the use of "abs_action". Did I miss something?

Thank you so much for your time.

Best regards,

Weikang

@cheng-chi
Copy link
Collaborator

Hi @wkwan7, good question. The conversion to positional control is done in 2 parts:

  1. Robomimic envs already have built-in support for positional control (they actually implemented velocity control on top of positional controller). This behavior is controled by "control_delta" argument for their env controllers, which is set to false by the abs_action flag here
  2. Robomimic's hdf5 datasets also need be converted to positional control using this script that outputs a new copy of the hdf5 with the only difference being the 7DoF action overwritten to positional actions. This script optionally verifies that the resulting positional actions result in the same robot behavior if you set the "--eval-dir" variable. If you are only interested in reproducing our result, the converted hdf5 files are already provided through datasets hosted on our server.

@wkwan7
Copy link
Author

wkwan7 commented Jun 2, 2023

Thank you so much for your quick response! This was really helpful.

@wkwan7 wkwan7 closed this as completed Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants