Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hoony-lab] User 도메인 구현 #12

Closed
4 of 5 tasks
hoony-lab opened this issue Aug 1, 2021 · 0 comments
Closed
4 of 5 tasks

[hoony-lab] User 도메인 구현 #12

hoony-lab opened this issue Aug 1, 2021 · 0 comments
Assignees
@hoony-lab
Labels
feature hoony-lab 후니의 이슈 user

Comments

@hoony-lab
Copy link
Member

hoony-lab commented Aug 1, 2021 •
edited

TODO

  • Project Setting
  • User : Entity, Repository, Service, Controller
  • Authentication : POST /api/users/login (No authentication)
    • token 제외
  • Registration : POST /api/users (No authentication)
    • token 제외
  • Test
    • 악
@hoony-lab hoony-lab self-assigned this Aug 1, 2021
hoony-lab added a commit that referenced this issue Aug 3, 2021
@hoony-lab
[#12] chore: jpa, security, lombok dependency 추가
7905b5a
hoony-lab added a commit that referenced this issue Aug 3, 2021
@hoony-lab
[#12] chore: lombok dependency 추가
9ebe365
hoony-lab added a commit that referenced this issue Aug 3, 2021
@hoony-lab
[#12] feat: User Entity 추가
ea16e7b
hoony-lab added a commit that referenced this issue Aug 3, 2021
@hoony-lab
[#12] feat: User에 BaseTimeEntity 추가
6713f70
hoony-lab added a commit that referenced this issue Aug 3, 2021
@hoony-lab
[#12] test: RealworldApplicationTest 수정
f8fda88
hoony-lab added a commit that referenced this issue Aug 3, 2021
@hoony-lab
[#12] feat: UserRepository 추가
6c474b6
hoony-lab added a commit that referenced this issue Aug 3, 2021
@hoony-lab
[#12] test: UserTest 추가
214377d 
user_builder
user_equals_and_hashCode
hoony-lab added a commit that referenced this issue Aug 3, 2021
@hoony-lab
[#12] feat: UserService 추가
d958304 
findAll, findById, findByEmail, save, deleteById
hoony-lab added a commit that referenced this issue Aug 3, 2021
@hoony-lab
[#12] test: UserServiceTest 추가
d2817b8 
save_and_findAll
save_and_findByEmail
save_and_findById
save_and_deleteById
save_and_deleteById_exception
hoony-lab added a commit that referenced this issue Aug 3, 2021
@hoony-lab
[#12] feat: UserJoinRequest 추가
48e6cf0 
`@JsonTypeName`, `@JsonTypeInfo` : Mapping Object
static `toUser` : convert DTO to Entity(User) for communicate within layers
hoony-lab added a commit that referenced this issue Aug 3, 2021
@hoony-lab
[#12] feat: UserResponse 추가
0623bb6 
`@JsonTypeName`, `@JsonTypeInfo` : Mapping Object
static `of`: convert Entity(User) to DTO for communicate within layers
hoony-lab added a commit that referenced this issue Aug 3, 2021
@hoony-lab
[#12] feat: UserLoginRequest 추가
e43fb1f 
`@JsonTypeName`, `@JsonTypeInfo` : Mapping Object
hoony-lab added a commit that referenced this issue Aug 3, 2021
@hoony-lab
[#12] feat: UserContoller 추가
e60bde9 
joinUser : `POST /api/users/`
loginUser : `POST /api/users/login`
hoony-lab added a commit that referenced this issue Aug 3, 2021
@hoony-lab
[#12] feat: SecurityConfig 추가
f77ffb7 
http authorizeRequest
- `/api/users/`, `/api/users/login/`
hoony-lab added a commit that referenced this issue Aug 3, 2021
@hoony-lab
[#12] feat: PasswordEncoder Bean 추가
6ce2d98 
PasswordEncoder >> BCryptPasswordEncoder
hoony-lab added a commit that referenced this issue Aug 3, 2021
@hoony-lab
[#12] feat: 비밀번호 암호화 및 확인 로직 추가
3612e99 
정리 필요
hoony-lab added a commit that referenced this issue Aug 3, 2021
@hoony-lab
[#12] test: UserControllerTest (@SpringBootTest) 추가
74abc86 
POST_api_users
POST_api_users_login

테스트에 대한 추가 이해와 유닛/단위 테스트 필요
hoony-lab added a commit that referenced this issue Aug 7, 2021
@hoony-lab
[#12] feat: passwordEncoder를 controller에서 service로 이동
496fc01
hoony-lab added a commit that referenced this issue Aug 7, 2021
@hoony-lab
[#12] chore
02df674
hoony-lab added a commit that referenced this issue Aug 7, 2021
@hoony-lab
[#12] test: userServiceTest 수정
fa4bffc 
`@SpringBootTest` >> `@ExtendWith(MockitoExtension.class)`
hoony-lab added a commit that referenced this issue Aug 7, 2021
@hoony-lab
[#12] test: userControllerTest 수정
e96f72a 
`@SpringBootTest` >> `@WebMvcTest(UserController.class)`
hoony-lab added a commit that referenced this issue Aug 7, 2021
@hoony-lab
[#12] feat: UserNotFoundException 삭제
35d86b6
@hoony-lab hoony-lab mentioned this issue Aug 7, 2021
Merged
5 tasks
hoony-lab added a commit that referenced this issue Aug 8, 2021
@hoony-lab @jinyoungchoi95
[#12] proposal:
5ce0037 
테이블 컬럼명을 맞추어야할 것 같아요 :)
from @jinyoungchoi95

물론, 명명 규칙에 의해서 자동으로 컬럼 명을 만들어주지만, 명명 규칙은 스프링 설정 파일에서도 변경 가능하고, 무엇이든 명시적으로 기술
from @kwj1270

Co-authored-by: 최진영 <jinyoungchoi95@gmail.com>
hoony-lab added a commit that referenced this issue Aug 8, 2021
@hoony-lab @jinyoungchoi95
[#12] proposal
812e27f 
Constructor가 필요한 클래스일까요?
from jinyoungchoi95

Co-authored-by: 최진영 <jinyoungchoi95@gmail.com>
hoony-lab added a commit that referenced this issue Aug 11, 2021
@hoony-lab
[#12] feat: UserRepositoryTest 추가
cec6f69 
`@DataJpaTest` 에 `JpaConfig` 추가해서 `BasetimeEntity` 테스트
hoony-lab added a commit that referenced this issue Aug 12, 2021
@hoony-lab @kwj1270
[#12] fix: UserService 중복되는 함수 삭제
86bf551 
`findByEmail이 중복되는 것 같은데 메서드로 분리해서 재사용도 좋을 것 같네요!`

Co-Authored-By: KimWooJae <50267433+kwj1270@users.noreply.github.com>
hoony-lab added a commit that referenced this issue Aug 12, 2021
@hoony-lab @kwj1270
[#12] fix: UserService 부가 기능 수정
51e51e6 
> `메서드로 분리해서 내부가 어떻게 돌아가는지 감추는 것`

`validateMatchesPassword` 메소드 추가하여 비밀번호 확인 로직 이동

Co-Authored-By: KimWooJae <50267433+kwj1270@users.noreply.github.com>
hoony-lab added a commit that referenced this issue Aug 14, 2021
@hoony-lab @povia
[#12] fix: UserService에 Transactional 수정
b8b81a5 
`@Transactional은 보통 Class단에 어노테이션으로 먹일 때에는 readOnly = true, CUD 메소드에 먹일 때 readOnly = false로 먹이니 참고만 해주셔용`

Co-Authored-By: povia <47127607+povia@users.noreply.github.com>
hoony-lab added a commit that referenced this issue Aug 16, 2021
@hoony-lab @povia
[#12] fix: UserService에 Transactional 수정
444d5a8 
`@Transactional은 보통 Class단에 어노테이션으로 먹일 때에는 readOnly = true, CUD 메소드에 먹일 때 readOnly = false로 먹이니 참고만 해주셔용`

Co-Authored-By: povia <47127607+povia@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hoony-lab hoony-lab

Labels
feature hoony-lab 후니의 이슈 user
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hoony-lab