backend changes for post read status sync #212
Conversation
server/resolver/resolver.go
Outdated
| DB *gorm.DB | ||
| SignalChans *SignalChannels | ||
| DB *gorm.DB | ||
| RedisClient *utils.RedisClient |
server/graph/schema.graphqls
Outdated
| postsId: [String!]! | ||
| } | ||
|
|
||
| input GetPostsReadStatusInput { |
There was a problem hiding this comment.
How does user call GetPostsReadStatus?
server/graph/schema.graphqls
Outdated
| @@ -166,6 +177,8 @@ type Mutation { | |||
| addWeiboSubSource(input: AddWeiboSubSourceInput!): SubSource | |||
|
|
|||
| syncUp(input: SeedStateInput): SeedState | |||
|
|
|||
| markPostsAsRead(input: MarkPostsAsReadInput!): Boolean! | |||
There was a problem hiding this comment.
You don't need to use Boolean! as return value. Error means incorrect
There was a problem hiding this comment.
ardatan/graphql-tools#277
I tried to return nothing but seems like graphql doesn't allow it so a boolean was a work around
server/graph/signal.graphqls
Outdated
| @@ -3,9 +3,11 @@ enum SignalType { | |||
| # Instruct client side to pull seed state. This is the first signal send to | |||
| # client side application. | |||
| SEED_STATE | |||
| READ_POST | |||
server/resolver/signal.resolvers.go
Outdated
| ) | ||
|
|
||
| func (r *signalResolver) SignalPayload(ctx context.Context, obj *model.Signal) (*string, error) { | ||
| panic(fmt.Errorf("not implemented")) |
There was a problem hiding this comment.
?
You need to copy from obj to output string, otherwise you won;t access it.
There was a problem hiding this comment.
since we need set unread functionality, I will change it from string to a struct
utils/redis_utils.go
Outdated
|
|
||
| var ctx = context.Background() | ||
|
|
||
| func GetRedisClient() *RedisClient { |
There was a problem hiding this comment.
I don't see this function accessed anywhere?
server/resolver/schema.resolvers.go
Outdated
| err := r.RedisClient.MarkPostsAsRead(input.PostsID, input.UserID) | ||
| if err != nil { | ||
| return false, err | ||
| } | ||
| return true, nil |
There was a problem hiding this comment.
Where do you push signal+payload to all end user sessions?
server/resolver/schema.resolvers.go
Outdated
| @@ -455,3 +467,13 @@ func (r *Resolver) Subscription() generated.SubscriptionResolver { return &subsc | |||
| type mutationResolver struct{ *Resolver } | |||
| type queryResolver struct{ *Resolver } | |||
| type subscriptionResolver struct{ *Resolver } | |||
|
|
|||
| // !!! WARNING !!! | |||
utils/redis_utils.go
Outdated
| "github.com/go-redis/redis/v8" | ||
| ) | ||
|
|
||
| type RedisClient struct { |
There was a problem hiding this comment.
This package is more like a "ReadStatusSotre" instead of Redis Client, maybe we can pass in a real redis client as a dependency, and keep only the business logic in this struct.
utils/redis_utils.go
Outdated
| })} | ||
| } | ||
|
|
||
| func PostKey(userId string, postId string) string { |
There was a problem hiding this comment.
wrap this in a struct and have a ser/deser API so we can extend and reuse in the future.
|
fix test error? |
gopricy
force-pushed
the
sync-post-read-status
branch
from
b3d419d
to
753d30a
Compare
model/post.go
Outdated
| @@ -97,4 +97,5 @@ type Post struct { | |||
| DeduplicateId string `json:"deduplicate_id"` | |||
| SemanticHashing string `json:"semantic_hashing"` | |||
| Tag string `json:"tag"` | |||
| IsRead bool `json:"is_read" gorm:"-"` | |||
There was a problem hiding this comment.
https://gorm.io/docs/models.html#Field-Level-Permission
It is an ignored field
No description provided.