Fix dynamic change of client_options.site #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The site updated for the `request_phase` using request params is also updated for the `callback_phase`
kriom
changed the title
|
@kriom can you add a test for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The client_options.site updated for the
request_phaseusing request params is also updated for thecallback_phasePerhaps I'm wrong, but as it is possible to dynamically update the target client_options.site (eg : https://login.salesforce.com or https://test.salesforce.com) during the
request_phaseit seems logical to use this same site during thecallback_phase, isn't ?Best regards,