Add a flag to trim whitespace when encrypting #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbvigilante
force-pushed
the
trim-flag
branch
from
8130436
to
2c67541
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use shush quite a lot at Redbubble. The most common issue we see comes when someone accidentally encrypts some whitespace, either by a) copying a string from a web form or b) pipes output from a shell command which automatically adds a newline.
Not sure if you consider this to be within the scope of the tool (totally understand if not!), but we thought it might make sense to have a flag in shush to (optionally, of course) trim whitespace when encrypting strings.
Let me know if you have any questions.