Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removing debug logging messages since they can cause race conditions #20

Merged
merged 1 commit into from
Apr 26, 2021
Merged

removing debug logging messages since they can cause race conditions #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions pyloot/collector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,8 @@ def get_object_descriptors(
"""
Return list of ::class::`ObjectDescriptor` instances for all objects in memory
after a call to gc.collect.

WARNING: Logging in this thread can cause a race condition if gevent is enabled
"""

if ignored:
Expand All @@ -139,26 +141,20 @@ def get_object_descriptors(

del ignored

logger.debug("Collecting gc")
gc.collect()

logger.debug("retrieving gc objects")
objs: List[object] = gc.get_objects()

logger.debug("filtering gc objects")
objs = [obj for obj in objs if _should_include_object(obj, ignore_set)]
logger.debug("getting data for each obj gc objects")
results = [get_data(obj) for obj in objs]
del objs
del ignore_set
child_to_parent: Dict[int, Set[int]] = defaultdict(set)

logger.debug("building child_to_parent map")
for descr in results:
for child_id in descr.child_ids:
child_to_parent[child_id].add(descr.id)

logger.debug("building parent_ids")
for descr in results:
if descr.id in child_to_parent:
descr.parent_ids.extend(child_to_parent[descr.id])
Expand Down