[feature] support OpenBSD #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
May 22, 2017 21:03
in most cases, you set `enbled: true` in a service task in tasks. it might look same when you set `enabled: true` in BOTH a service task and a service handler, but it would bites you when you have `arguments` in a service task. `arguments` is not implemented in all platforms. it is in OpenBSD. when both the service task and the handler has `enabled: true`, but only one of them has `arguments`, then, `idempotency_test` will mysteriously fail because the one with `arguments` modifies `rc.conf.local` and the other as well. this happens when: * the platform is OpenBSD * a service in task and a service in handler has `enabled: true` * only one of them has `arguments` * `arguments` is not identical to the default
fixes #14
mitsururike
reviewed
May 23, 2017
tasks/install-OpenBSD.yml
Outdated
| - name: Create _fluentd user | ||
| user: | ||
| name: _fluentd | ||
| comment: Fluend daemon |
mitsururike
reviewed
May 23, 2017
vars/OpenBSD.yml
Outdated
| __fluentd_package_name: rubygem-fluentd | ||
| __fluentd_service_name: fluentd | ||
| __fluentd_config_dir: "/etc/fluentd" | ||
| __fluentd_config_file: "{{ __fluentd_config_dir }}/fluent.conf" |
There was a problem hiding this comment.
s/__fluentd_config_dir/fluentd_config_dir/ or users must modify fluentd_config_file when fluentd_config_dir is set.
mitsururike
reviewed
May 23, 2017
README.md
Outdated
| | `__fluentd_package_name` | `rubygem-fluentd` | | ||
| | `__fluentd_service_name` | `fluentd` | | ||
| | `__fluentd_config_dir` | `/etc/fluentd` | | ||
| | `__fluentd_config_file` | `{{ __fluentd_config_dir }}/fluent.conf` | |
There was a problem hiding this comment.
s/__fluentd_config_dir/fluentd_config_dir/
mitsururike
approved these changes
May 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #14
ruby version is hard-coded and should be fixed by writing
ansible-role-ruby