Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve ux across application #101

Closed
xpanvictor opened this issue Jun 20, 2024 · 7 comments · Fixed by #133
Closed

improve ux across application #101

xpanvictor opened this issue Jun 20, 2024 · 7 comments · Fixed by #133
Assignees
@xpanvictor
Labels
frontend ODHack Issue label for ODHack

Comments

@xpanvictor
Copy link
Collaborator

xpanvictor commented Jun 20, 2024 •
edited
Loading

The goal here is to reduce loading time and where unavoidable, ensure a loading state to improve the overall user experience across the app. Loading the site is a bit slow and can reduce the quality users get from the flow.

With improving this ux, notice some of these issues

  1. Wallet connect modal doesn't close automatically after connection
  2. White screens on clicking some of the buttons and links on the game play
  3. Some buttons don't respond since they have no listeners
@linear Linear
Copy link

linear bot commented Jun 20, 2024

MAN-20 Improve UX across app

@xpanvictor xpanvictor self-assigned this Jun 20, 2024
xpanvictor added a commit that referenced this issue Jun 20, 2024
@xpanvictor
refr(white-screen): replaces logo a tag to Link and removes accompany…
2bf9c54 
…ing white screen #101
xpanvictor added a commit that referenced this issue Jun 20, 2024
@xpanvictor
refr(white-screen): changes to Link to remove white screens across mu…
e6455c2 
…ltiple pages #101
@okhaimie-dev okhaimie-dev changed the title Improve UX across app improve ux across application Jun 20, 2024
@okhaimie-dev
Copy link
Contributor

@xpanvictor will this be a blocker to other developers? and are you will to assist in-case a conflict occurs?

@xpanvictor
Copy link
Collaborator Author

It won't, and yh, I'll be up for conflict resolutions.

@xpanvictor
Copy link
Collaborator Author

@okhaimie-dev I'll also be making PRs to develop as soon as possible.

@okhaimie-dev
Copy link
Contributor

@xpanvictor take a look at this
#96

and work with the developer assigned to this issue, to make sure there is no conflict here.

@okhaimie-dev okhaimie-dev added frontend ODHack Issue label for ODHack labels Jun 20, 2024
@xpanvictor
Copy link
Collaborator Author

Noted

xpanvictor added a commit that referenced this issue Jun 24, 2024
@xpanvictor
fix(source): handles merge conflicts on #101
8f339d3
xpanvictor added a commit that referenced this issue Jun 24, 2024
@xpanvictor
refr(logic): simplifies the lobby component #101
7145c29
xpanvictor added a commit that referenced this issue Jun 25, 2024
@xpanvictor
fix(elements): completes some white screens, error with buttons and t…
86acd82 
…hen refactors the gameplay pits resolves #101
xpanvictor added a commit that referenced this issue Jun 29, 2024
@xpanvictor
Merge branch 'refr/loading-states' of github.com:realm-of-ra/mancala …
8c9bb09 
…into refr/loading-states

and resolves #101
xpanvictor added a commit that referenced this issue Jun 29, 2024
@xpanvictor
refr(Lobby): Separates lobby's concerns to keep components folder clean
304c82a 
on #101
@xpanvictor
Copy link
Collaborator Author

#133

@xpanvictor xpanvictor mentioned this issue Jun 29, 2024
Merged
supreme2580 pushed a commit that referenced this issue Jun 29, 2024
@xpanvictor
Couples some changes from refr/loading-states with some other changes, …
e917f12 
…resolves #101 (#133)

* refr(Lobby): Separates lobby's concerns to keep components folder clean
on #101

* fix(duel): abstracts game run into its function and separates the UI
from the functionalities

* refr: buttons dont need Link parent, used navigate API instead

* chore(packaging): removes ide files and clutter

* chore(packaging): removes ide files and clutter

* refr(gameplay): Removes redundancy with pits by mapping and resolves
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xpanvictor xpanvictor

Labels
frontend ODHack Issue label for ODHack
Projects
None yet
Milestone
No milestone
2 participants
@okhaimie-dev @xpanvictor