Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EmptyCountRule catches words that include "count" #1622

Closed
bdrelling opened this issue Jun 14, 2017 · 2 comments
Closed

EmptyCountRule catches words that include "count" #1622

bdrelling opened this issue Jun 14, 2017 · 2 comments
Labels
bug

Comments

@bdrelling
Copy link

bdrelling commented Jun 14, 2017 •
edited
Loading

EmptyCountRule.swift:34

let pattern = "count\\s*(==|!=|<|<=|>|>=)\\s*0"

This should change so that it doesn't match words that end in count, only the word count itself.

ie. discount == 0
@bdrelling bdrelling changed the title EmptyCountRule catches "discount == 0" EmptyCountRule catches words that include "count" Jun 14, 2017
@marcelofabri
Copy link
Collaborator

Duplicate of #827

@marcelofabri
Copy link
Collaborator

Actually, not a duplicate.

@marcelofabri marcelofabri reopened this Jun 14, 2017
marcelofabri added a commit that referenced this issue Jun 14, 2017
@marcelofabri
Fix empty_count false positive in words with "count"
6c9766d 
Fix #1622
@marcelofabri marcelofabri mentioned this issue Jun 14, 2017
Merged
@gwsounddsg gwsounddsg mentioned this issue Jul 4, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marcelofabri @bdrelling