Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive in rule explicit_type_interface with allowRedundancy #2636

Closed
Dschee opened this Issue Feb 12, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@Dschee
Copy link
Collaborator

Dschee commented Feb 12, 2019

For this code

private let l10n = L10n.Communication.self

using this configuration

explicit_type_interface:
  allow_redundancy: true
  excluded:
    - local

there shouldn't be any warnings, but there is.

Rationale: The usage of this rule here is mostly for improving readability, not performance of the compiler. We also try to prevent redundant type annotations, why explicitly writing the type here wouldn't be right. Thus this rules behavior must be changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.