New MARK rule does not detect "//MARK: - sometext"

[Sega-Zero]

Latest swiftlint doesn't detect //MARK: - mark text as a warning, but it should. Am i right?

[nikolay-dementiev]

Hello.

Why you think that the construction should be marked as warning?

[Sega-Zero]

No space after //

[nikolay-dementiev]

.. I can't to find any apple's guidelines, in which says, that need space between "//" and "MARK:" ((

Have you some links to share?

[Sega-Zero]

take a look at new MARK rule, please. #749

[nikolay-dementiev]

That's right. This issue has been resolved. And in repository it is already exists.

Please, try to update your SwiftLint on your device

For example, on my computer, it would be something like this command: "brew update && brew upgrade 'brew outdated'" in Terminal app (see there http://www.commandlinefu.com/commands/view/4831/update-all-packages-installed-via-homebrew)

[Sega-Zero]

Ok, I'll be more specific:

~ $ swiftlint version
0.12.0
~ $ echo //MARK: mark text | swiftlint lint --use-stdin
<nopath>:1:2: warning: Mark Violation: MARK comment should be in valid format. (mark)
Done linting! Found 1 violation, 0 serious in 1 file.

$ echo // MARK: mark text | swiftlint lint --use-stdin
Done linting! Found 0 violations, 0 serious in 1 file.

$ echo //MARK: - mark text | swiftlint lint --use-stdin
Done linting! Found 0 violations, 0 serious in 1 file.

The last line should produce a warning

[nikolay-dementiev]

Thank you for your patience in explaining the issue's reasons.

The latest version of SwiftLint, which is currently has stored in the repository, provided by your version of the code is described approximately by such rule: "

 nonTriggeringExamples: [
            "// MARK: good\n",
            "// MARK: - good\n",
            "// MARK: -\n"
        ]

  This variants of behavior is specifically described and located in the the exclusion.
ie .:
// MARK: - mark the text - this is good
// MARK: -mark the text - this is bad

[jpsim]

Sorry it took a while to get to this. I've pushed a fix in #888.