Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add path or file based exclusion to the linter #100

Closed
wants to merge 2 commits into from

Conversation

nwest
Copy link

@nwest nwest commented Aug 25, 2015

Taking a stab at #6.

It would be pretty easy to add regex based exclusion too.

@jpsim
Copy link
Collaborator

jpsim commented Aug 25, 2015

This is great, @nwest! I actually wrote similar functionality in #99 just yesterday (although you configure excluded paths via a YAML file rather than a command-line option). It'd be great to compare these two approaches and stick with the more efficient one. What do you think?

@nwest
Copy link
Author

nwest commented Aug 26, 2015

Ah dang! I wish I would have noticed that.

I think your yaml based config is more robust. Will we be able to switch up the config without committing updates? (e.g for CI)

@jpsim
Copy link
Collaborator

jpsim commented Aug 26, 2015

Will we be able to switch up the config without committing updates? (e.g for CI)

No, I don't intend on backporting YAML configuration support to Swift 1.2 unless there's strong demand.

Let me know if you think there's still good reason to keep this PR open, otherwise please close @nwest. I hope you'll continue to contribute to SwiftLint in the future!

@nwest nwest closed this Aug 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants