Fix false positive on shorthand_operator rule #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 danger |
Current coverage is 82.23% (diff: 100%)@@ master #1157 diff @@
==========================================
Files 165 165
Lines 8151 8151
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 6703 6703
Misses 1448 1448
Partials 0 0
|
ghost
reviewed
Jan 11, 2017
|
|
||
| private static let pattern: String = { | ||
| let escapedOperators = allOperators.map { "\\\($0)" }.joined() | ||
| let operators = "[\(escapedOperators)]" | ||
| let escaped = { (operators: [String]) -> String in |
There was a problem hiding this comment.
You use this pattern to escape characters in OperatorFunctionWhitespaceRule and OperatorUsageWhitespaceRule (and possibly others). Might be worth refactoring this into a helper?
There was a problem hiding this comment.
I don't think it's complex enough to justify the additional complexity
jpsim
approved these changes
Jan 11, 2017
This was referenced Jan 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1156