Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2075 - New rule - Empty (whitespace) lines in function bodies #2076

Closed
wants to merge 16 commits into from

Conversation

driver733
Copy link

As per #2075
I have implemented a new rule that prohibits empty (whitespace) lines in function bodies.

@driver733 driver733 changed the title #2075 - Empty (whitespace) lines in function bodies #2075 - New rule - Empty (whitespace) lines in function bodies Mar 1, 2018
@SwiftLintBot
Copy link

16170 Warnings
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/App/AppDelegate.swift:17:5: error: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 2 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/App/AppDelegate.swift:17:5: warning: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 2 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/App/AppDelegate.swift:29:13: error: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 1 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/App/AppDelegate.swift:29:13: warning: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 1 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/Preferences.swift:42:5: error: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 2 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/Preferences.swift:42:5: warning: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 2 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/Preferences.swift:103:5: error: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 1 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/Preferences.swift:103:5: warning: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 1 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/AssetLoaderDelegate.swift:14:1: error: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 2 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/AssetLoaderDelegate.swift:14:1: warning: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 2 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/AssetLoaderDelegate.swift:58:5: error: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 4 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/AssetLoaderDelegate.swift:58:5: warning: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 4 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/AssetLoaderDelegate.swift:83:5: error: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 4 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/AssetLoaderDelegate.swift:83:5: warning: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 4 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoCache.swift:61:5: error: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 2 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoCache.swift:61:5: warning: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 2 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoCache.swift:77:5: error: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 1 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoCache.swift:77:5: warning: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 1 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoCache.swift:96:5: error: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 2 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoCache.swift:96:5: warning: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 2 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoCache.swift:109:5: error: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 3 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoCache.swift:109:5: warning: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 3 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoCache.swift:140:5: error: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 6 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoCache.swift:140:5: warning: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 6 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoCache.swift:173:5: error: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 4 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoCache.swift:173:5: warning: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 4 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoCache.swift:197:5: error: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 5 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoCache.swift:197:5: warning: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 5 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoCache.swift:218:5: error: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 3 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoCache.swift:218:5: warning: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 3 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoCache.swift:234:5: error: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 6 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoCache.swift:234:5: warning: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 6 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoCache.swift:263:5: error: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 7 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoCache.swift:263:5: warning: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 7 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Extensions/CollectionType+Shuffling.swift:12:14: error: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 1 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Extensions/CollectionType+Shuffling.swift:12:14: warning: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 1 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoLoader.swift:30:5: error: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 9 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoLoader.swift:30:5: warning: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 9 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoLoader.swift:77:5: error: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 3 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoLoader.swift:77:5: warning: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 3 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoLoader.swift:93:5: error: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 15 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoLoader.swift:93:5: warning: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 15 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoLoader.swift:160:5: error: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 1 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoLoader.swift:160:5: warning: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 1 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoLoader.swift:168:5: error: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 8 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoLoader.swift:168:5: warning: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 8 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoLoader.swift:202:5: error: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 7 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoLoader.swift:202:5: warning: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 7 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoDownload.swift:60:5: error: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 7 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoDownload.swift:60:5: warning: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 7 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoDownload.swift:90:5: error: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 1 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoDownload.swift:90:5: warning: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 1 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoDownload.swift:100:5: error: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 9 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoDownload.swift:100:5: warning: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 9 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoDownload.swift:141:5: error: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 1 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoDownload.swift:141:5: warning: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 1 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoDownload.swift:153:5: error: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 4 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoDownload.swift:153:5: warning: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 4 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoDownload.swift:180:5: error: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 1 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoDownload.swift:180:5: warning: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 1 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoDownload.swift:187:5: error: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 6 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoDownload.swift:187:5: warning: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 6 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoDownload.swift:218:5: error: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 3 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoDownload.swift:218:5: warning: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 3 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoDownload.swift:237:5: error: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 4 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoDownload.swift:237:5: warning: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 4 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoDownload.swift:275:5: error: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 6 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoDownload.swift:275:5: warning: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 6 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Views/CheckCellView.swift:29:5: error: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 1 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Views/CheckCellView.swift:29:5: warning: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 1 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:70:14: error: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 1 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:70:14: warning: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 1 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:77:14: error: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 8 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:77:14: warning: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 8 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:125:15: error: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 1 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:125:15: warning: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 1 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:132:15: error: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 3 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:132:15: warning: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 3 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:161:15: error: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 2 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:161:15: warning: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 2 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:185:5: error: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 2 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:185:5: warning: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 2 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:200:15: error: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 2 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:200:15: warning: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 2 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:219:5: error: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 1 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:219:5: warning: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 1 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:230:5: error: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 7 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:230:5: warning: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 7 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:267:5: error: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 6 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:267:5: warning: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 6 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:307:5: error: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 4 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:307:5: warning: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 4 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:331:5: error: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 1 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:331:5: warning: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 1 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:366:5: error: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 10 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:366:5: warning: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 10 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:430:5: error: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 5 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:430:5: warning: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 5 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:475:15: error: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 2 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:475:15: warning: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 2 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:488:5: error: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 8 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:488:5: warning: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 8 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:522:5: error: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 1 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:522:5: warning: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 1 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Tests/PreferencesTests.swift:22:5: error: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 1 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Tests/PreferencesTests.swift:22:5: warning: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 1 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/ManifestLoader.swift:31:5: error: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 4 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/ManifestLoader.swift:31:5: warning: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 4 lines (function_body_whitespace_lines)
⚠️ This PR introduced a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/ManifestLoader.swift:55:5: error: Function Body Whitespace Lines Violation: Function body should span 0 comment and whitespace lines or less : currently spans 3 lines (function_body_whitespace_lines)
⚠️ Danger found 16170 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 109.
12 Messages
📖 Linting Aerial with this PR took 0.76s vs 0.45s on master (68% slower)
📖 Linting Alamofire with this PR took 5.68s vs 3.94s on master (44% slower)
📖 Linting Firefox with this PR took 18.67s vs 15.49s on master (20% slower)
📖 Linting Kickstarter with this PR took 23.85s vs 21.88s on master (9% slower)
📖 Linting Moya with this PR took 2.16s vs 2.1s on master (2% slower)
📖 Linting Nimble with this PR took 2.26s vs 2.0s on master (12% slower)
📖 Linting Quick with this PR took 0.75s vs 0.6s on master (25% slower)
📖 Linting Realm with this PR took 4.73s vs 3.9s on master (21% slower)
📖 Linting SourceKitten with this PR took 1.24s vs 1.19s on master (4% slower)
📖 Linting Sourcery with this PR took 6.01s vs 5.28s on master (13% slower)
📖 Linting Swift with this PR took 22.36s vs 15.08s on master (48% slower)
📖 Linting WordPress with this PR took 23.83s vs 17.2s on master (38% slower)

Generated by 🚫 Danger

@codecov-io
Copy link

Codecov Report

Merging #2076 into master will increase coverage by <.01%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2076      +/-   ##
==========================================
+ Coverage   89.68%   89.68%   +<.01%     
==========================================
  Files         259      261       +2     
  Lines       15020    15100      +80     
  Branches      977      980       +3     
==========================================
+ Hits        13471    13543      +72     
- Misses       1532     1540       +8     
  Partials       17       17
Impacted Files Coverage Δ
...SwiftLintFramework/Extensions/File+SwiftLint.swift 91.97% <0%> (-2.77%) ⬇️
Tests/SwiftLintFrameworkTests/RulesTests.swift 100% <100%> (ø) ⬆️
...rkTests/FunctionBodyWhitespaceLinesRuleTests.swift 100% <100%> (ø)
...mework/Rules/FunctionBodyWhitespaceLinesRule.swift 95% <95%> (ø)
Source/SwiftLintFramework/Models/Command.swift 97.82% <0%> (+2.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52274de...57dc67d. Read the comment docs.

@@ -0,0 +1,48 @@
//
// FunctionBodyLengthRule.swift
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy and paste leftover.

@Jeehut
Copy link
Collaborator

Jeehut commented Feb 25, 2019

@driver733 Could you please add triggering and non-triggering examples and rebase this?

Please note that I have never seen this style of coding and can't imagine this to be considered a "good practice" (and definitely not a best practice) – but that's my personal experience so far and should not prevent this rule from being added as an optional rule. Unless there's rules we don't merge if there's no real "community acceptance"? @jpsim @marcelofabri

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants