New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2075 - New rule - Empty (whitespace) lines in function bodies #2076
Conversation
Replaced loop with flatMap
Edited rules.md
Codecov Report
@@ Coverage Diff @@
## master #2076 +/- ##
==========================================
+ Coverage 89.68% 89.68% +<.01%
==========================================
Files 259 261 +2
Lines 15020 15100 +80
Branches 977 980 +3
==========================================
+ Hits 13471 13543 +72
- Misses 1532 1540 +8
Partials 17 17
Continue to review full report at Codecov.
|
@@ -0,0 +1,48 @@ | |||
// | |||
// FunctionBodyLengthRule.swift |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy and paste leftover.
@driver733 Could you please add triggering and non-triggering examples and rebase this? Please note that I have never seen this style of coding and can't imagine this to be considered a "good practice" (and definitely not a best practice) – but that's my personal experience so far and should not prevent this rule from being added as an optional rule. Unless there's rules we don't merge if there's no real "community acceptance"? @jpsim @marcelofabri |
As per #2075
I have implemented a new rule that prohibits empty (whitespace) lines in function bodies.