Fix #2231

[Coder-256]

SwiftLint fails with an error in enums with associated types in Xcode 10 due to the identifier_name rule. This fixes that error.

[SwiftLintBot]

	12 Messages
📖	Linting Aerial with this PR took 0.39s vs 0.36s on master (8% slower)
📖	Linting Alamofire with this PR took 3.36s vs 3.08s on master (9% slower)
📖	Linting Firefox with this PR took 12.87s vs 11.33s on master (13% slower)
📖	Linting Kickstarter with this PR took 20.0s vs 16.41s on master (21% slower)
📖	Linting Moya with this PR took 1.99s vs 1.82s on master (9% slower)
📖	Linting Nimble with this PR took 1.77s vs 1.47s on master (20% slower)
📖	Linting Quick with this PR took 0.51s vs 0.49s on master (4% slower)
📖	Linting Realm with this PR took 3.74s vs 3.12s on master (19% slower)
📖	Linting SourceKitten with this PR took 1.07s vs 0.97s on master (10% slower)
📖	Linting Sourcery with this PR took 4.86s vs 4.31s on master (12% slower)
📖	Linting Swift with this PR took 30.25s vs 27.46s on master (10% slower)
📖	Linting WordPress with this PR took 15.23s vs 14.26s on master (6% slower)

Generated by 🚫 Danger

[ronanrodrigo]

Maybe for better meaning you could separate in two variables. Like:

let isFunction = SwiftDeclarationKind.functionKinds.contains(kind)
let isEnumelement = kind == .enumelement

Or jus update the isFunction to something like isFunctionOrEnumelement.

[marcelofabri]

We shouldn't change the rule behavior (i.e. oss-check shouldn't report any changes). The problem is that key.name for an enum element now contains the parameters labels. Apparently, key.nameoffset and key.namelength only contain the name range (without parameters), so we should use that instead.

[Coder-256]

@marcelofabri I'm having some trouble testing locally (many sourcekit errors, which it looks like they're already working on in SourceKitten). Let's see if these changes pass tests.

[codecov-io]

Codecov Report

Merging #2232 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2232      +/-   ##
==========================================
+ Coverage   92.03%   92.04%   +<.01%     
==========================================
  Files         283      283              
  Lines       14246    14253       +7     
==========================================
+ Hits        13112    13119       +7     
  Misses       1134     1134

Impacted Files	Coverage Δ
.../SwiftLintFramework/Rules/IdentifierNameRule.swift	98.83% <100%> (+0.1%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c0e7c8...0c6442e. Read the comment docs.

[dominik-hadl]

Can we get this merged in soon? :)

[marcelofabri]

I've tested this and it looks like SourceKit reports incorrect values for key.nameoffset and key.namelength is the enum case contains backticks (e.g. `private`).

We should fill an issue in bugs.swift.org and meanwhile we can get the substring from key.name up to the first (.

To avoid any potential issues, I'd only do that if kind == .enumcase && SwiftVersion.current > .fourDotOne.

[marcelofabri]

requires two trailing spaces and lines should be limited to 80 chars as described in CONTRIBUTING.md: https://github.com/realm/SwiftLint/blob/master/CONTRIBUTING.md#tracking-changes

[krodak]

Any update on this?

[marcelofabri]

Closing this in favor of #2255

[Coder-256]

Thank you @marcelofabri!