Don't trigger explicit_type_interface on if case statements

CHANGELOG.md

@@ -37,7 +37,9 @@
 
 #### Bug Fixes
 
-* None.
+
+* Don't trigger `explicit_type_interface` on `if case let` statements.  
+  [Carlos Millani](https://github.com/cmillani)
 
 ## 0.35.0: Secondary Lint Trap
 

Source/SwiftLintFramework/Models/MasterRuleList.swift

@@ -1,4 +1,4 @@
-// Generated using Sourcery 0.17.0 — https://github.com/krzysztofzablocki/Sourcery
+// Generated using Sourcery 0.16.2 — https://github.com/krzysztofzablocki/Sourcery
 // DO NOT EDIT
 
 public let masterRuleList = RuleList(rules: [

Source/SwiftLintFramework/Rules/Idiomatic/ExplicitTypeInterfaceRule.swift

@@ -96,6 +96,7 @@ public struct ExplicitTypeInterfaceRule: OptInRule, ConfigurationProviderRule {
                 (!dictionary.isInitCall(file: file) && !dictionary.isTypeReferenceAssignment(file: file))
             ),
             !parentStructure.contains([.forEach, .guard]),
+            !parentStructure.isIfCaseCall(),
             !parentStructure.caseStatementPatternRanges.contains(offset),
             !parentStructure.caseExpressionRanges.contains(offset),
             !file.captureGroupByteRanges.contains(offset) else {
@@ -115,6 +116,12 @@ private extension Dictionary where Key == String, Value == SourceKitRepresentabl
         return typeName != nil
     }
 
+    func isIfCaseCall() -> Bool {
+        let isOnlyArgumentInCall = self.kind == SwiftExpressionKind.call.rawValue
+        let isOneOfManyArguments = self.kind == SwiftExpressionKind.argument.rawValue
+        return isOnlyArgumentInCall || isOneOfManyArguments
+    }
+
     func isInitCall(file: File) -> Bool {
         guard
             let nameOffset = nameOffset,

Tests/LinuxMain.swift

@@ -1,4 +1,4 @@
-// Generated using Sourcery 0.17.0 — https://github.com/krzysztofzablocki/Sourcery
+// Generated using Sourcery 0.16.2 — https://github.com/krzysztofzablocki/Sourcery
 // DO NOT EDIT
 
 @testable import SwiftLintFrameworkTests
@@ -443,6 +443,7 @@ extension ExplicitTypeInterfaceRuleTests {
         ("testAllowRedundancy", testAllowRedundancy),
         ("testEmbededInStatements", testEmbededInStatements),
         ("testCaptureGroup", testCaptureGroup),
+        ("testTryCatchDeclarations", testTryCatchDeclarations),
         ("testFastEnumerationDeclaration", testFastEnumerationDeclaration),
         ("testSwitchCaseDeclarations", testSwitchCaseDeclarations)
     ]

Tests/SwiftLintFrameworkTests/AutomaticRuleTests.generated.swift

@@ -1,4 +1,4 @@
-// Generated using Sourcery 0.17.0 — https://github.com/krzysztofzablocki/Sourcery
+// Generated using Sourcery 0.16.2 — https://github.com/krzysztofzablocki/Sourcery
 // DO NOT EDIT
 
 import SwiftLintFramework

Tests/SwiftLintFrameworkTests/ExplicitTypeInterfaceRuleTests.swift

@@ -1,6 +1,7 @@
 import SwiftLintFramework
 import XCTest
 
+//swiftlint:disable type_body_length
 class ExplicitTypeInterfaceRuleTests: XCTestCase {
     func testExplicitTypeInterface() {
         verifyRule(ExplicitTypeInterfaceRule.description)
@@ -126,6 +127,27 @@ class ExplicitTypeInterfaceRuleTests: XCTestCase {
         verifyRule(description)
     }
 
+    func testTryCatchDeclarations() {
+        let nonTriggeringExaples = [
+            """
+            enum FooError: Error {
+                case errorWithValue(value: Int)
+            }
+            do {
+                throw FooError.errorWithValue(value: 2)
+            } catch FooError.errorWithValue(let value) {
+                print(value)
+            }
+            """
+        ]
+
+        let triggeringExamples = ExplicitTypeInterfaceRule.description.triggeringExamples
+        let description = ExplicitTypeInterfaceRule.description
+            .with(triggeringExamples: triggeringExamples)
+            .with(nonTriggeringExamples: nonTriggeringExaples)
+        verifyRule(description)
+    }
+
     func testFastEnumerationDeclaration() {
         let nonTriggeringExaples = [
             """
@@ -178,6 +200,28 @@ class ExplicitTypeInterfaceRuleTests: XCTestCase {
                 case var (x, y): break
                 }
             }
+            """,
+            """
+            enum Foo {
+              case caseOne(propOne: Int)
+            }
+
+            enum Bar: Error {
+              case testError
+              case multiVariable(foo: Int, bar: String)
+            }
+
+            let testA: Foo = .caseOne(propOne: 2)
+
+            if case let Foo.caseOne(propOne) = testA { }
+
+            if case Foo.caseOne(let propOne) = testA { }
+
+            if 5 > 2, case Foo.caseOne(let propOne) = testA { }
+
+            let multiVariable: Error = Bar.multiVariable(foo: 10, bar: "")
+
+            if case Bar.multiVariable(let foo, _) = multiVariable { }
             """
         ]