Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update intersection #5023

Merged
merged 2 commits into from
May 19, 2023
Merged

Update intersection #5023

merged 2 commits into from
May 19, 2023

Conversation

Haoocen
Copy link
Contributor

@Haoocen Haoocen commented May 19, 2023

According to https://developer.apple.com/documentation/coregraphics/1455346-cgrectintersection, the replacement for CGRectIntersection(_:_:) is CGRect.intersection(_:)

@SwiftLintBot
Copy link

SwiftLintBot commented May 19, 2023

17 Messages
📖 Linting Aerial with this PR took 1.1s vs 1.09s on main (0% slower)
📖 Linting Alamofire with this PR took 1.41s vs 1.42s on main (0% faster)
📖 Linting Brave with this PR took 7.68s vs 7.65s on main (0% slower)
📖 Linting DuckDuckGo with this PR took 3.71s vs 3.7s on main (0% slower)
📖 Linting Firefox with this PR took 9.69s vs 9.69s on main (0% slower)
📖 Linting Kickstarter with this PR took 10.37s vs 10.31s on main (0% slower)
📖 Linting Moya with this PR took 0.58s vs 0.59s on main (1% faster)
📖 Linting NetNewsWire with this PR took 3.17s vs 3.15s on main (0% slower)
📖 Linting Nimble with this PR took 0.66s vs 0.65s on main (1% slower)
📖 Linting PocketCasts with this PR took 7.66s vs 7.62s on main (0% slower)
📖 Linting Quick with this PR took 0.33s vs 0.33s on main (0% slower)
📖 Linting Realm with this PR took 11.9s vs 11.9s on main (0% slower)
📖 Linting Sourcery with this PR took 2.27s vs 2.29s on main (0% faster)
📖 Linting Swift with this PR took 4.83s vs 4.82s on main (0% slower)
📖 Linting VLC with this PR took 1.37s vs 1.36s on main (0% slower)
📖 Linting Wire with this PR took 8.46s vs 8.47s on main (0% faster)
📖 Linting WordPress with this PR took 11.87s vs 11.84s on main (0% slower)

Generated by 🚫 Danger

Copy link
Collaborator

@SimplyDanny SimplyDanny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Could you please add a CHANGELOG entry?

@SimplyDanny SimplyDanny enabled auto-merge (squash) May 19, 2023 19:13
@SimplyDanny SimplyDanny disabled auto-merge May 19, 2023 19:13
@SimplyDanny SimplyDanny enabled auto-merge (squash) May 19, 2023 19:15
@SimplyDanny SimplyDanny merged commit 7541279 into realm:main May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants