-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SwiftSyntax to version 510.0.0 #5479
Conversation
Here's an example of your CHANGELOG entry: * Update SwiftSyntax to version 510.0.0.
[SimplyDanny](https://github.com/SimplyDanny)
[#issue_number](https://github.com/realm/SwiftLint/issues/issue_number) note: There are two invisible spaces after the entry's text. Generated by 🚫 Danger |
The 9-13% perf hit is unfortunate. Would be good to share those numbers with the SwiftSyntax folks. |
de35bc8
to
b32d1eb
Compare
While the improvements in memory management in apple/swift-syntax#2537 look very promising, the decision is against adding them to any Swift 510.x.y release. We might only see it in 600.0.0 earliest. So what to do? Skip 510.x.y entirely and wait for 600.x.y or accept a performance drop of ~10%? @jpsim, what's your opinion? |
We should stay on the latest SwiftSyntax release because it’ll parse Swift 5.10 code more accurately. Higher accuracy is worth a 10% hit in perf in the uncached case. |
b32d1eb
to
f0ed4c0
Compare
No description provided.