Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SwiftSyntax to version 510.0.0 #5479

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

SimplyDanny
Copy link
Collaborator

No description provided.

@SwiftLintBot
Copy link

SwiftLintBot commented Mar 3, 2024

2 Warnings
⚠️ If this is a user-facing change, please include a CHANGELOG entry to credit yourself!
You can find it at CHANGELOG.md.
⚠️ This PR may need tests.
17 Messages
📖 Linting Aerial with this PR took 1.27s vs 1.12s on main (13% slower)
📖 Linting Alamofire with this PR took 1.78s vs 1.61s on main (10% slower)
📖 Linting Brave with this PR took 10.35s vs 9.38s on main (10% slower)
📖 Linting DuckDuckGo with this PR took 5.39s vs 4.91s on main (9% slower)
📖 Linting Firefox with this PR took 13.85s vs 12.77s on main (8% slower)
📖 Linting Kickstarter with this PR took 12.24s vs 11.25s on main (8% slower)
📖 Linting Moya with this PR took 0.68s vs 0.62s on main (9% slower)
📖 Linting NetNewsWire with this PR took 3.41s vs 3.08s on main (10% slower)
📖 Linting Nimble with this PR took 1.02s vs 0.92s on main (10% slower)
📖 Linting PocketCasts with this PR took 9.86s vs 9.09s on main (8% slower)
📖 Linting Quick with this PR took 0.45s vs 0.41s on main (9% slower)
📖 Linting Realm with this PR took 6.36s vs 5.74s on main (10% slower)
📖 Linting Sourcery with this PR took 3.05s vs 2.79s on main (9% slower)
📖 Linting Swift with this PR took 6.15s vs 5.59s on main (10% slower)
📖 Linting VLC with this PR took 1.66s vs 1.52s on main (9% slower)
📖 Linting Wire with this PR took 23.31s vs 21.2s on main (9% slower)
📖 Linting WordPress with this PR took 15.18s vs 13.66s on main (11% slower)

Here's an example of your CHANGELOG entry:

* Update SwiftSyntax to version 510.0.0.  
  [SimplyDanny](https://github.com/SimplyDanny)
  [#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)

note: There are two invisible spaces after the entry's text.

Generated by 🚫 Danger

@jpsim
Copy link
Collaborator

jpsim commented Mar 3, 2024

The 9-13% perf hit is unfortunate. Would be good to share those numbers with the SwiftSyntax folks.

@SimplyDanny
Copy link
Collaborator Author

SimplyDanny commented Mar 9, 2024

While the improvements in memory management in apple/swift-syntax#2537 look very promising, the decision is against adding them to any Swift 510.x.y release. We might only see it in 600.0.0 earliest.

So what to do? Skip 510.x.y entirely and wait for 600.x.y or accept a performance drop of ~10%? @jpsim, what's your opinion?

@jpsim
Copy link
Collaborator

jpsim commented Mar 9, 2024

We should stay on the latest SwiftSyntax release because it’ll parse Swift 5.10 code more accurately. Higher accuracy is worth a 10% hit in perf in the uncached case.

@SimplyDanny SimplyDanny enabled auto-merge (squash) March 9, 2024 20:18
@SimplyDanny SimplyDanny merged commit 5bfe329 into realm:main Mar 9, 2024
11 of 12 checks passed
@SimplyDanny SimplyDanny deleted the swift-syntax-510.0.0 branch March 11, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants