Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SwiftSyntax version 600.0.0-prerelease-2024-03-11 #5527

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SimplyDanny
Copy link
Collaborator

No description provided.

@SwiftLintBot
Copy link

SwiftLintBot commented Apr 5, 2024

486 Warnings
⚠️ If this is a user-facing change, please include a CHANGELOG entry to credit yourself!
You can find it at CHANGELOG.md.
⚠️ This PR introduced a violation in Realm: /Realm/ObjectServerTests/ClientResetTests.swift:74:52: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments (unneeded_parentheses_in_closure_argument)
⚠️ This PR introduced a violation in Realm: /Realm/ObjectServerTests/ClientResetTests.swift:74:53: error: Identifier Name Violation: Variable name 'e' should be between 3 and 40 characters long (identifier_name)
⚠️ This PR introduced a violation in Realm: /Realm/ObjectServerTests/SwiftObjectServerTests.swift:671:52: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments (unneeded_parentheses_in_closure_argument)
⚠️ This PR introduced a violation in Realm: /Realm/ObjectServerTests/SwiftObjectServerTests.swift:756:52: warning: Unneeded Parentheses in Closure Argument Violation: Parentheses are not needed when declaring closure arguments (unneeded_parentheses_in_closure_argument)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Concurrency/Task+TaskExecutor.swift:152:7: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Concurrency/Task+TaskExecutor.swift:166:13: error: Identifier Name Violation: Function name '_abi__withTaskExecutorPreference(:operation:)' should start with a lowercase character (identifier_name)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Concurrency/Task+TaskExecutor.swift:177:7: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Concurrency/Task+TaskExecutor.swift:188:1: warning: Extension Access Modifier Violation: Prefer to use extension access modifiers (extension_access_modifier)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Concurrency/Task+TaskExecutor.swift:229:18: warning: Explicit Init Violation: Explicitly calling .init() should be avoided (explicit_init)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Concurrency/Task+TaskExecutor.swift:234:9: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Concurrency/Task+TaskExecutor.swift:235:27: warning: Multiline Arguments Violation: Arguments should be either on the same line, or one per line (multiline_arguments)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Concurrency/Task+TaskExecutor.swift:235:47: warning: Multiline Arguments Violation: Arguments should be either on the same line, or one per line (multiline_arguments)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Concurrency/Task+TaskExecutor.swift:236:29: warning: Multiline Arguments Violation: Arguments should be either on the same line, or one per line (multiline_arguments)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Concurrency/Task+TaskExecutor.swift:238:30: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line (multiline_arguments_brackets)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Concurrency/Task+TaskExecutor.swift:244:9: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Concurrency/Task+TaskExecutor.swift:245:40: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line (multiline_arguments_brackets)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Concurrency/Task+TaskExecutor.swift:254:1: warning: Extension Access Modifier Violation: Prefer to use extension access modifiers (extension_access_modifier)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Concurrency/Task+TaskExecutor.swift:290:18: warning: Explicit Init Violation: Explicitly calling .init() should be avoided (explicit_init)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Concurrency/Task+TaskExecutor.swift:295:9: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Concurrency/Task+TaskExecutor.swift:296:27: warning: Multiline Arguments Violation: Arguments should be either on the same line, or one per line (multiline_arguments)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Concurrency/Task+TaskExecutor.swift:296:47: warning: Multiline Arguments Violation: Arguments should be either on the same line, or one per line (multiline_arguments)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Concurrency/Task+TaskExecutor.swift:297:29: warning: Multiline Arguments Violation: Arguments should be either on the same line, or one per line (multiline_arguments)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Concurrency/Task+TaskExecutor.swift:299:30: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line (multiline_arguments_brackets)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Concurrency/Task+TaskExecutor.swift:304:9: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Concurrency/Task+TaskExecutor.swift:305:40: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line (multiline_arguments_brackets)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Concurrency/Task+TaskExecutor.swift:316:1: warning: Extension Access Modifier Violation: Prefer to use extension access modifiers (extension_access_modifier)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Concurrency/Task+TaskExecutor.swift:353:9: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Concurrency/Task+TaskExecutor.swift:354:27: warning: Multiline Arguments Violation: Arguments should be either on the same line, or one per line (multiline_arguments)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Concurrency/Task+TaskExecutor.swift:354:47: warning: Multiline Arguments Violation: Arguments should be either on the same line, or one per line (multiline_arguments)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Concurrency/Task+TaskExecutor.swift:355:30: warning: Multiline Arguments Violation: Arguments should be either on the same line, or one per line (multiline_arguments)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Concurrency/Task+TaskExecutor.swift:357:30: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line (multiline_arguments_brackets)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Concurrency/Task+TaskExecutor.swift:362:9: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Concurrency/Task+TaskExecutor.swift:363:40: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line (multiline_arguments_brackets)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Concurrency/Task+TaskExecutor.swift:373:1: warning: Extension Access Modifier Violation: Prefer to use extension access modifiers (extension_access_modifier)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Concurrency/Task+TaskExecutor.swift:412:9: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Concurrency/Task+TaskExecutor.swift:413:27: warning: Multiline Arguments Violation: Arguments should be either on the same line, or one per line (multiline_arguments)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Concurrency/Task+TaskExecutor.swift:413:47: warning: Multiline Arguments Violation: Arguments should be either on the same line, or one per line (multiline_arguments)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Concurrency/Task+TaskExecutor.swift:414:30: warning: Multiline Arguments Violation: Arguments should be either on the same line, or one per line (multiline_arguments)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Concurrency/Task+TaskExecutor.swift:416:30: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line (multiline_arguments_brackets)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Concurrency/Task+TaskExecutor.swift:421:9: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Concurrency/Task+TaskExecutor.swift:422:40: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line (multiline_arguments_brackets)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Concurrency/Task+TaskExecutor.swift:434:1: warning: Extension Access Modifier Violation: Prefer to use extension access modifiers (extension_access_modifier)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Concurrency/Task+TaskExecutor.swift:445:9: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Concurrency/Task+TaskExecutor.swift:454:15: error: Identifier Name Violation: Function name '_getPreferredTaskExecutor()' should start with a lowercase character (identifier_name)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Concurrency/Task+TaskExecutor.swift:456:1: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly (explicit_acl)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Concurrency/Task+TaskExecutor.swift:456:1: warning: Explicit Top Level ACL Violation: Top-level declarations should specify Access Control Level keywords explicitly (explicit_top_level_acl)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Concurrency/Task+TaskExecutor.swift:460:15: error: Identifier Name Violation: Function name 'pushTaskExecutorPreference(:)' should start with a lowercase character (identifier_name)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Concurrency/Task+TaskExecutor.swift:465:15: error: Identifier Name Violation: Function name '_popTaskExecutorPreference(record:)' should start with a lowercase character (identifier_name)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Concurrency/Task+TaskExecutor.swift:475:15: error: Identifier Name Violation: Function name '_getUndefinedTaskExecutor()' should start with a lowercase character (identifier_name)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Distributed/DistributedActor.swift:369:19: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Distributed/DistributedActor.swift:371:7: warning: Superfluous Else Violation: Else branches should be avoided when the previous if-block exits the current scope (superfluous_else)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Distributed/DistributedActor.swift:379:15: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly (explicit_acl)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Distributed/DistributedActor.swift:379:20: error: Identifier Name Violation: Function name '_abi_whenLocal(:)' should start with a lowercase character (identifier_name)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Distributed/DistributedActor.swift:389:1: warning: Extension Access Modifier Violation: Prefer to use extension access modifiers (extension_access_modifier)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Distributed/DistributedActor.swift:392:22: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Distributed/DistributedActor.swift:392:26: error: Identifier Name Violation: Variable name '__actorUnownedExecutor' should only contain alphanumeric and other allowed characters (identifier_name)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Distributed/DistributedActor.swift:395:7: warning: Superfluous Else Violation: Else branches should be avoided when the previous if-block exits the current scope (superfluous_else)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Distributed/DistributedActor.swift:428:13: error: Identifier Name Violation: Function name '_isRemoteActor(:)' should start with a lowercase character (identifier_name)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Distributed/DistributedActor.swift:434:13: error: Identifier Name Violation: Function name '_isLocalActor(:)' should start with a lowercase character (identifier_name)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Distributed/DistributedActor.swift:435:3: warning: Implicit Return Violation: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Distributed/DistributedActor.swift:441:1: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly (explicit_acl)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Distributed/DistributedActor.swift:441:1: warning: Explicit Top Level ACL Violation: Top-level declarations should specify Access Control Level keywords explicitly (explicit_top_level_acl)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Distributed/DistributedActor.swift:441:6: error: Identifier Name Violation: Function name 'distributedActorRemoteInitialize(:)' should start with a lowercase character (identifier_name)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Distributed/DistributedActor.swift:446:17: error: Type Name Violation: Type name '_DistributedActorStub' should only contain alphanumeric and other allowed characters (type_name)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Distributed/DistributedActor.swift:446:8: warning: One Declaration per File Violation: Only a single declaration is allowed in a file (one_declaration_per_file)
⚠️ This PR introduced a violation in Swift: /stdlib/public/Distributed/DistributedActor.swift:449:13: error: Identifier Name Violation: Function name '_distributedStubFatalError(function:)' should start with a lowercase character (identifier_name)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Builtin.swift:1037:24: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line (multiline_arguments_brackets)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Builtin.swift:1037:49: warning: Multiline Arguments Violation: Arguments should be either on the same line, or one per line (multiline_arguments)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Builtin.swift:1038:5: warning: Vertical Parameter Alignment on Call Violation: Function parameters should be aligned vertically if they're in multiple lines in a method call (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Builtin.swift:1039:42: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line (multiline_arguments_brackets)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Builtin.swift:1045:1: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly (explicit_acl)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Builtin.swift:1045:1: warning: Explicit Top Level ACL Violation: Top-level declarations should specify Access Control Level keywords explicitly (explicit_top_level_acl)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Builtin.swift:1045:6: error: Identifier Name Violation: Function name '_abi_withoutActuallyEscaping(:do:)' should start with a lowercase character (identifier_name)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Builtin.swift:1052:24: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line (multiline_arguments_brackets)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Builtin.swift:1052:49: warning: Multiline Arguments Violation: Arguments should be either on the same line, or one per line (multiline_arguments)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Builtin.swift:1053:5: warning: Vertical Parameter Alignment on Call Violation: Function parameters should be aligned vertically if they're in multiple lines in a method call (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Builtin.swift:1054:42: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line (multiline_arguments_brackets)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Builtin.swift:1061:13: error: Identifier Name Violation: Function name 'openExistential(:do:)' should start with a lowercase character (identifier_name)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Builtin.swift:1068:24: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line (multiline_arguments_brackets)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Builtin.swift:1068:49: warning: Multiline Arguments Violation: Arguments should be either on the same line, or one per line (multiline_arguments)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Builtin.swift:1069:5: warning: Vertical Parameter Alignment on Call Violation: Function parameters should be aligned vertically if they're in multiple lines in a method call (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Builtin.swift:1070:42: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line (multiline_arguments_brackets)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Builtin.swift:1076:1: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly (explicit_acl)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Builtin.swift:1076:1: warning: Explicit Top Level ACL Violation: Top-level declarations should specify Access Control Level keywords explicitly (explicit_top_level_acl)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Builtin.swift:1076:6: error: Identifier Name Violation: Function name '_abi_openExistential(:do:)' should start with a lowercase character (identifier_name)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Builtin.swift:1083:24: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line (multiline_arguments_brackets)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Builtin.swift:1083:49: warning: Multiline Arguments Violation: Arguments should be either on the same line, or one per line (multiline_arguments)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Builtin.swift:1084:5: warning: Vertical Parameter Alignment on Call Violation: Function parameters should be aligned vertically if they're in multiple lines in a method call (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Builtin.swift:1085:42: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line (multiline_arguments_brackets)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Builtin.swift:1098:1: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Builtin.swift:1098:6: error: Identifier Name Violation: Function name 'getGlobalStringTablePointer(:)' should start with a lowercase character (identifier_name)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Builtin.swift:1099:3: warning: Implicit Return Violation: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Builtin.swift:1105:1: warning: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports (attributes)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Builtin.swift:1105:6: error: Identifier Name Violation: Function name '_allocateVector(elementType:capacity:)' should start with a lowercase character (identifier_name)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Collection.swift:1197:9: error: Identifier Name Violation: Variable name 'n' should be between 3 and 40 characters long (identifier_name)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Collection.swift:1197:9: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Collection.swift:1202:9: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Collection.swift:1205:9: error: Identifier Name Violation: Variable name 'i' should be between 3 and 40 characters long (identifier_name)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Collection.swift:1205:9: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Collection.swift:1221:3: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly (explicit_acl)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Collection.swift:1221:8: error: Identifier Name Violation: Function name '_rethrows_map(:)' should start with a lowercase character (identifier_name)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Collection.swift:1248:39: error: Identifier Name Violation: Variable name 'k' should be between 3 and 40 characters long (identifier_name)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Collection.swift:1250:9: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Collection.swift:1275:38: error: Identifier Name Violation: Variable name 'k' should be between 3 and 40 characters long (identifier_name)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Collection.swift:1277:75: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line (multiline_arguments_brackets)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Collection.swift:1278:9: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Collection.swift:1279:21: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line (multiline_arguments_brackets)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Collection.swift:1279:9: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Collection.swift:1280:25: warning: Multiline Arguments Violation: Arguments should be either on the same line, or one per line (multiline_arguments)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Collection.swift:1280:44: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line (multiline_arguments_brackets)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Collection.swift:1280:7: warning: Vertical Parameter Alignment on Call Violation: Function parameters should be aligned vertically if they're in multiple lines in a method call (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Collection.swift:1297:9: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Collection.swift:1328:65: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line (multiline_arguments_brackets)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Collection.swift:1329:21: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line (multiline_arguments_brackets)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Collection.swift:1329:9: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Collection.swift:1330:28: warning: Multiline Arguments Violation: Arguments should be either on the same line, or one per line (multiline_arguments)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Collection.swift:1330:47: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line (multiline_arguments_brackets)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Collection.swift:1330:7: warning: Vertical Parameter Alignment on Call Violation: Function parameters should be aligned vertically if they're in multiple lines in a method call (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Collection.swift:1347:9: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Collection.swift:1378:65: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line (multiline_arguments_brackets)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Collection.swift:1379:9: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Collection.swift:1380:23: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line (multiline_arguments_brackets)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Collection.swift:1380:9: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Collection.swift:1381:25: warning: Multiline Arguments Violation: Arguments should be either on the same line, or one per line (multiline_arguments)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Collection.swift:1381:44: warning: Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line (multiline_arguments_brackets)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Collection.swift:1381:7: warning: Vertical Parameter Alignment on Call Violation: Function parameters should be aligned vertically if they're in multiple lines in a method call (vertical_parameter_alignment_on_call)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Collection.swift:1421:5: warning: Implicit Return Violation: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Collection.swift:1459:5: warning: Implicit Return Violation: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Collection.swift:1494:5: warning: Implicit Return Violation: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Collection.swift:1570:9: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Collection.swift:1571:9: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Collection.swift:1574:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Collection.swift:1593:1: warning: Extension Access Modifier Violation: Prefer to use extension access modifiers (extension_access_modifier)
⚠️ This PR introduced a violation in Swift: /stdlib/public/core/Collection.swift:1647:5: warning: Implicit Return Violation: Prefer implicit returns in closures, functions and getters (implicit_return)
⚠️ Danger found 486 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 135.
90 Messages
📖 Linting Aerial with this PR took 0.65s vs 0.79s on main (17% faster)
📖 Linting Alamofire with this PR took 0.88s vs 1.14s on main (22% faster)
📖 Linting Brave with this PR took 5.05s vs 6.43s on main (21% faster)
📖 Linting DuckDuckGo with this PR took 2.82s vs 3.55s on main (20% faster)
📖 Linting Firefox with this PR took 7.63s vs 9.07s on main (15% faster)
📖 Linting Kickstarter with this PR took 6.88s vs 8.14s on main (15% faster)
📖 Linting Moya with this PR took 0.4s vs 0.47s on main (14% faster)
📖 Linting NetNewsWire with this PR took 1.96s vs 2.49s on main (21% faster)
📖 Linting Nimble with this PR took 0.56s vs 0.67s on main (16% faster)
📖 Linting PocketCasts with this PR took 5.94s vs 6.85s on main (13% faster)
📖 Linting Quick with this PR took 0.29s vs 0.33s on main (12% faster)
📖 Linting Realm with this PR took 3.51s vs 4.15s on main (15% faster)
📖 Linting Sourcery with this PR took 1.64s vs 2.04s on main (19% faster)
📖 Linting Swift with this PR took 3.06s vs 3.89s on main (21% faster)
📖 Linting VLC with this PR took 0.87s vs 1.09s on main (20% faster)
📖 Linting Wire with this PR took 11.57s vs 14.2s on main (18% faster)
📖 Linting WordPress with this PR took 7.46s vs 9.46s on main (21% faster)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/AsyncCompactMapSequence.swift:150:11: warning: Return Value from Void Function Violation: Returning values from Void functions should be avoided (return_value_from_void_function)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/AsyncCompactMapSequence.swift:154:11: warning: Return Value from Void Function Violation: Returning values from Void functions should be avoided (return_value_from_void_function)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/AsyncDropFirstSequence.swift:137:11: warning: Return Value from Void Function Violation: Returning values from Void functions should be avoided (return_value_from_void_function)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/AsyncDropFirstSequence.swift:142:7: warning: Return Value from Void Function Violation: Returning values from Void functions should be avoided (return_value_from_void_function)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/AsyncDropWhileSequence.swift:148:11: warning: Return Value from Void Function Violation: Returning values from Void functions should be avoided (return_value_from_void_function)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/AsyncDropWhileSequence.swift:152:11: warning: Return Value from Void Function Violation: Returning values from Void functions should be avoided (return_value_from_void_function)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/AsyncDropWhileSequence.swift:155:7: warning: Return Value from Void Function Violation: Returning values from Void functions should be avoided (return_value_from_void_function)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/AsyncFilterSequence.swift:133:11: warning: Return Value from Void Function Violation: Returning values from Void functions should be avoided (return_value_from_void_function)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/AsyncFilterSequence.swift:136:11: warning: Return Value from Void Function Violation: Returning values from Void functions should be avoided (return_value_from_void_function)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/AsyncFlatMapSequence.swift:296:13: warning: Return Value from Void Function Violation: Returning values from Void functions should be avoided (return_value_from_void_function)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/AsyncFlatMapSequence.swift:305:13: warning: Return Value from Void Function Violation: Returning values from Void functions should be avoided (return_value_from_void_function)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/AsyncFlatMapSequence.swift:316:13: warning: Return Value from Void Function Violation: Returning values from Void functions should be avoided (return_value_from_void_function)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/AsyncFlatMapSequence.swift:323:7: warning: Return Value from Void Function Violation: Returning values from Void functions should be avoided (return_value_from_void_function)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/AsyncIteratorProtocol.swift:109:74: warning: Variable Declaration Whitespace Violation: Variable declarations should be separated from other statements by a blank line (let_var_whitespace)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/AsyncIteratorProtocol.swift:109:75: error: Identifier Name Violation: Variable name 'Failure' should start with a lowercase character (identifier_name)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/AsyncIteratorProtocol.swift:121:7: warning: Return Value from Void Function Violation: Returning values from Void functions should be avoided (return_value_from_void_function)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/AsyncIteratorProtocol.swift:136:5: warning: Return Value from Void Function Violation: Returning values from Void functions should be avoided (return_value_from_void_function)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/AsyncMapSequence.swift:135:9: warning: Return Value from Void Function Violation: Returning values from Void functions should be avoided (return_value_from_void_function)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/AsyncMapSequence.swift:137:7: warning: Return Value from Void Function Violation: Returning values from Void functions should be avoided (return_value_from_void_function)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/AsyncPrefixSequence.swift:127:9: warning: Return Value from Void Function Violation: Returning values from Void functions should be avoided (return_value_from_void_function)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/AsyncPrefixSequence.swift:129:9: warning: Return Value from Void Function Violation: Returning values from Void functions should be avoided (return_value_from_void_function)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/AsyncPrefixWhileSequence.swift:139:11: warning: Return Value from Void Function Violation: Returning values from Void functions should be avoided (return_value_from_void_function)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/AsyncPrefixWhileSequence.swift:144:7: warning: Return Value from Void Function Violation: Returning values from Void functions should be avoided (return_value_from_void_function)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/AsyncThrowingCompactMapSequence.swift:169:11: warning: Return Value from Void Function Violation: Returning values from Void functions should be avoided (return_value_from_void_function)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/AsyncThrowingCompactMapSequence.swift:173:13: warning: Return Value from Void Function Violation: Returning values from Void functions should be avoided (return_value_from_void_function)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/AsyncThrowingCompactMapSequence.swift:180:7: warning: Return Value from Void Function Violation: Returning values from Void functions should be avoided (return_value_from_void_function)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/AsyncThrowingDropWhileSequence.swift:172:11: warning: Return Value from Void Function Violation: Returning values from Void functions should be avoided (return_value_from_void_function)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/AsyncThrowingDropWhileSequence.swift:177:13: warning: Return Value from Void Function Violation: Returning values from Void functions should be avoided (return_value_from_void_function)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/AsyncThrowingDropWhileSequence.swift:185:9: warning: Return Value from Void Function Violation: Returning values from Void functions should be avoided (return_value_from_void_function)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/AsyncThrowingDropWhileSequence.swift:187:7: warning: Return Value from Void Function Violation: Returning values from Void functions should be avoided (return_value_from_void_function)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/AsyncThrowingFilterSequence.swift:153:11: warning: Return Value from Void Function Violation: Returning values from Void functions should be avoided (return_value_from_void_function)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/AsyncThrowingFilterSequence.swift:157:13: warning: Return Value from Void Function Violation: Returning values from Void functions should be avoided (return_value_from_void_function)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/AsyncThrowingFilterSequence.swift:165:7: warning: Return Value from Void Function Violation: Returning values from Void functions should be avoided (return_value_from_void_function)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/AsyncThrowingFlatMapSequence.swift:194:13: warning: Return Value from Void Function Violation: Returning values from Void functions should be avoided (return_value_from_void_function)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/AsyncThrowingFlatMapSequence.swift:201:13: warning: Return Value from Void Function Violation: Returning values from Void functions should be avoided (return_value_from_void_function)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/AsyncThrowingFlatMapSequence.swift:212:13: warning: Return Value from Void Function Violation: Returning values from Void functions should be avoided (return_value_from_void_function)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/AsyncThrowingFlatMapSequence.swift:220:7: warning: Return Value from Void Function Violation: Returning values from Void functions should be avoided (return_value_from_void_function)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/AsyncThrowingMapSequence.swift:154:9: warning: Return Value from Void Function Violation: Returning values from Void functions should be avoided (return_value_from_void_function)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/AsyncThrowingMapSequence.swift:157:9: warning: Return Value from Void Function Violation: Returning values from Void functions should be avoided (return_value_from_void_function)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/AsyncThrowingPrefixWhileSequence.swift:155:13: warning: Return Value from Void Function Violation: Returning values from Void functions should be avoided (return_value_from_void_function)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/AsyncThrowingPrefixWhileSequence.swift:164:7: warning: Return Value from Void Function Violation: Returning values from Void functions should be avoided (return_value_from_void_function)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/AsyncThrowingStream.swift:257:20: warning: Operator Usage Whitespace Violation: Operators should be surrounded by a single whitespace when they are being used (operator_usage_whitespace)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/AsyncThrowingStream.swift:444:7: warning: Return Value from Void Function Violation: Returning values from Void functions should be avoided (return_value_from_void_function)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/Task+TaskExecutor.swift:132:8: warning: Function Default Parameter at End Violation: Prefer to locate parameters with defaults toward the end of the parameter list (function_default_parameter_at_end)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/TaskGroup.swift:1327:30: warning: Return Value from Void Function Violation: Returning values from Void functions should be avoided (return_value_from_void_function)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/TaskGroup.swift:1331:11: warning: Return Value from Void Function Violation: Returning values from Void functions should be avoided (return_value_from_void_function)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/TaskGroup.swift:1333:9: warning: Return Value from Void Function Violation: Returning values from Void functions should be avoided (return_value_from_void_function)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Collection.swift:1194:34: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly (explicit_acl)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Collection.swift:1194:34: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Collection.swift:1194:34: warning: Variable Declaration Whitespace Violation: Variable declarations should be separated from other statements by a blank line (let_var_whitespace)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Collection.swift:1194:35: error: Identifier Name Violation: Variable name 'E' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Optional.swift:206:44: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly (explicit_acl)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Optional.swift:206:44: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Optional.swift:206:44: warning: Variable Declaration Whitespace Violation: Variable declarations should be separated from other statements by a blank line (let_var_whitespace)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Optional.swift:206:45: error: Identifier Name Violation: Variable name 'E' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Result.swift:260:7: warning: Return Value from Void Function Violation: Returning values from Void functions should be avoided (return_value_from_void_function)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Sequence.swift:687:34: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly (explicit_acl)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Sequence.swift:687:34: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Sequence.swift:687:34: warning: Variable Declaration Whitespace Violation: Variable declarations should be separated from other statements by a blank line (let_var_whitespace)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Sequence.swift:687:35: error: Identifier Name Violation: Variable name 'E' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Swift: /stdlib/public/core/SequenceAlgorithms.swift:607:38: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly (explicit_acl)
📖 This PR fixed a violation in Swift: /stdlib/public/core/SequenceAlgorithms.swift:607:38: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Swift: /stdlib/public/core/SequenceAlgorithms.swift:607:38: warning: Variable Declaration Whitespace Violation: Variable declarations should be separated from other statements by a blank line (let_var_whitespace)
📖 This PR fixed a violation in Swift: /stdlib/public/core/SequenceAlgorithms.swift:607:39: error: Identifier Name Violation: Variable name 'E' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Swift: /stdlib/public/core/SequenceAlgorithms.swift:611:36: warning: Colon Spacing Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals (colon)
📖 This PR fixed a violation in Swift: /stdlib/public/core/UnsafeBufferPointerSlice.swift:283:68: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly (explicit_acl)
📖 This PR fixed a violation in Swift: /stdlib/public/core/UnsafeBufferPointerSlice.swift:283:68: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Swift: /stdlib/public/core/UnsafeBufferPointerSlice.swift:283:68: warning: Variable Declaration Whitespace Violation: Variable declarations should be separated from other statements by a blank line (let_var_whitespace)
📖 This PR fixed a violation in Swift: /stdlib/public/core/UnsafeBufferPointerSlice.swift:283:69: error: Identifier Name Violation: Variable name 'E' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Swift: /stdlib/public/core/UnsafeRawPointer.swift:391:49: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly (explicit_acl)
📖 This PR fixed a violation in Swift: /stdlib/public/core/UnsafeRawPointer.swift:391:49: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Swift: /stdlib/public/core/UnsafeRawPointer.swift:391:49: warning: Variable Declaration Whitespace Violation: Variable declarations should be separated from other statements by a blank line (let_var_whitespace)
📖 This PR fixed a violation in Swift: /stdlib/public/core/UnsafeRawPointer.swift:391:50: error: Identifier Name Violation: Variable name 'E' should be between 3 and 40 characters long (identifier_name)

Here's an example of your CHANGELOG entry:

* Use SwiftSyntax version 600.0.0-prerelease-2024-03-11.  
  [SimplyDanny](https://github.com/SimplyDanny)
  [#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)

note: There are two invisible spaces after the entry's text.

Generated by 🚫 Danger

@SimplyDanny
Copy link
Collaborator Author

SimplyDanny commented Apr 13, 2024

OSS findings look all valid. Most of them stem from a fix that parses @Sendable used on closure parameters as an attribute on the argument list as opposed to an attribute with arguments as before.

Other differences are caused by support for new keywords like __consuming and typed-throws.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants