Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make postprocessors non-throwing #5539

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

SimplyDanny
Copy link
Collaborator

Failing immediately when a property is invalid is too strict. It feels sufficient to allow to report an issue but otherwise continue with a default value instead of stopping execution completely.

@SwiftLintBot
Copy link

SwiftLintBot commented Apr 23, 2024

1 Warning
⚠️ If this is a user-facing change, please include a CHANGELOG entry to credit yourself!
You can find it at CHANGELOG.md.
17 Messages
📖 Linting Aerial with this PR took 1.12s vs 1.13s on main (0% faster)
📖 Linting Alamofire with this PR took 1.64s vs 1.64s on main (0% slower)
📖 Linting Brave with this PR took 9.42s vs 9.42s on main (0% slower)
📖 Linting DuckDuckGo with this PR took 5.24s vs 5.2s on main (0% slower)
📖 Linting Firefox with this PR took 12.12s vs 12.17s on main (0% faster)
📖 Linting Kickstarter with this PR took 11.41s vs 11.44s on main (0% faster)
📖 Linting Moya with this PR took 0.62s vs 0.64s on main (3% faster)
📖 Linting NetNewsWire with this PR took 3.5s vs 3.5s on main (0% slower)
📖 Linting Nimble with this PR took 0.93s vs 0.97s on main (4% faster)
📖 Linting PocketCasts with this PR took 9.38s vs 9.29s on main (0% slower)
📖 Linting Quick with this PR took 0.42s vs 0.42s on main (0% slower)
📖 Linting Realm with this PR took 5.82s vs 5.84s on main (0% faster)
📖 Linting Sourcery with this PR took 2.88s vs 2.91s on main (1% faster)
📖 Linting Swift with this PR took 5.69s vs 5.71s on main (0% faster)
📖 Linting VLC with this PR took 1.52s vs 1.53s on main (0% faster)
📖 Linting Wire with this PR took 21.11s vs 20.92s on main (0% slower)
📖 Linting WordPress with this PR took 14.01s vs 14.0s on main (0% slower)

Here's an example of your CHANGELOG entry:

* Make postprocessors non-throwing.  
  [SimplyDanny](https://github.com/SimplyDanny)
  [#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)

note: There are two invisible spaces after the entry's text.

Generated by 🚫 Danger

Failing immediately when a property is invalid is too strict. It feels
sufficient to allow to report an issue but otherwise continue with a default
value instead of stopping execution completely.
@SimplyDanny SimplyDanny enabled auto-merge (squash) April 23, 2024 20:43
@SimplyDanny SimplyDanny merged commit 1b7fbc4 into realm:main Apr 23, 2024
11 of 12 checks passed
@SimplyDanny SimplyDanny deleted the non-throwing-postprocessor branch April 23, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants