New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve README.md #5543
Improve README.md #5543
Conversation
Hey @SimplyDanny, I realize this is a large diff but @tinder-cfuller and I were inspired to give the README some love after contributing the plugin work. We felt that the plugin info improvements would be helpful for the community when adopting the plugins. Once we got started, we decided to look at the Installation and Setup info more holistically. We hope you like how it turned out. Thank you. |
Hi @SimplyDanny What are your thoughts about getting this PR merged in before the next SwiftLint release? Please advise. Thank you! 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A highly welcome cleanup! Thanks.
I suggest a few changes and fixes of which not all are caused by your rewrite.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! Really great ⭐
I am suggesting that some of the important notes become regular notes since a) there are too many that are important and b) not having an important note immediately following each header will improve readability.
Generated by 🚫 Danger |
Co-authored-by: Danny Mösch <danny.moesch@icloud.com>
Co-authored-by: Christopher Fuller <christopher.fuller@gotinder.com>
Co-authored-by: Christopher Fuller <christopher.fuller@gotinder.com>
Co-authored-by: Christopher Fuller <christopher.fuller@gotinder.com>
Co-authored-by: Christopher Fuller <christopher.fuller@gotinder.com>
Co-authored-by: Christopher Fuller <christopher.fuller@gotinder.com>
Hi @SimplyDanny How is this looking to you now? Do you have any additional revisions before this may be merged in? Please advise. Thank you! |
Feels very structured and easily readable. Thank you both for all the fixes and further improvements! |
As a follow up to the recent PRs improving the build tool plugin and adding the command plugin, this PR incorporates several improvements to the README throughout. For example, some out dated information has been removed, sections have been reordered to improve organization, the video introduction was moved towards the top and some screenshots have been replaced with code to enable copy and paste. Information within Installation and Setup was de-mixed and moved to their appropriate sections. Headings and formatting have been tidied up throughout the document. Lastly, consistent line wrapping to 80 columns was applied to match the bulk of the existing text.