Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve README.md #5543

Merged
merged 20 commits into from May 15, 2024
Merged

Improve README.md #5543

merged 20 commits into from May 15, 2024

Conversation

garricn
Copy link
Contributor

@garricn garricn commented Apr 27, 2024

As a follow up to the recent PRs improving the build tool plugin and adding the command plugin, this PR incorporates several improvements to the README throughout. For example, some out dated information has been removed, sections have been reordered to improve organization, the video introduction was moved towards the top and some screenshots have been replaced with code to enable copy and paste. Information within Installation and Setup was de-mixed and moved to their appropriate sections. Headings and formatting have been tidied up throughout the document. Lastly, consistent line wrapping to 80 columns was applied to match the bulk of the existing text.

@garricn
Copy link
Contributor Author

garricn commented Apr 27, 2024

Hey @SimplyDanny, I realize this is a large diff but @tinder-cfuller and I were inspired to give the README some love after contributing the plugin work. We felt that the plugin info improvements would be helpful for the community when adopting the plugins. Once we got started, we decided to look at the Installation and Setup info more holistically. We hope you like how it turned out. Thank you.

@tinder-cfuller
Copy link
Contributor

Hi @SimplyDanny What are your thoughts about getting this PR merged in before the next SwiftLint release? Please advise. Thank you! 🙏

Copy link
Collaborator

@SimplyDanny SimplyDanny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A highly welcome cleanup! Thanks.

I suggest a few changes and fixes of which not all are caused by your rewrite.

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
Copy link
Contributor

@tinder-cfuller tinder-cfuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! Really great ⭐

I am suggesting that some of the important notes become regular notes since a) there are too many that are important and b) not having an important note immediately following each header will improve readability.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@SwiftLintBot
Copy link

1 Warning
⚠️ Big PR

Generated by 🚫 Danger

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
garricn and others added 19 commits May 13, 2024 13:02
Co-authored-by: Danny Mösch <danny.moesch@icloud.com>
Co-authored-by: Christopher Fuller <christopher.fuller@gotinder.com>
Co-authored-by: Christopher Fuller <christopher.fuller@gotinder.com>
Co-authored-by: Christopher Fuller <christopher.fuller@gotinder.com>
Co-authored-by: Christopher Fuller <christopher.fuller@gotinder.com>
Co-authored-by: Christopher Fuller <christopher.fuller@gotinder.com>
@tinder-cfuller
Copy link
Contributor

Hi @SimplyDanny How is this looking to you now? Do you have any additional revisions before this may be merged in? Please advise. Thank you!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@SimplyDanny
Copy link
Collaborator

Feels very structured and easily readable. Thank you both for all the fixes and further improvements!

@SimplyDanny SimplyDanny enabled auto-merge (squash) May 15, 2024 20:58
@SimplyDanny SimplyDanny merged commit 7ec2238 into realm:main May 15, 2024
12 checks passed
@garricn garricn deleted the improve-readme branch May 15, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants