Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore but report invalid keys #5567

Merged
merged 1 commit into from
May 11, 2024

Conversation

SimplyDanny
Copy link
Collaborator

@SimplyDanny SimplyDanny commented May 11, 2024

In other words, don't fall back to the default configuration due to invalid keys.

Fixes #5565.

@SwiftLintBot
Copy link

SwiftLintBot commented May 11, 2024

17 Messages
📖 Linting Aerial with this PR took 0.8s vs 0.81s on main (1% faster)
📖 Linting Alamofire with this PR took 1.14s vs 1.17s on main (2% faster)
📖 Linting Brave with this PR took 6.52s vs 6.68s on main (2% faster)
📖 Linting DuckDuckGo with this PR took 3.44s vs 3.49s on main (1% faster)
📖 Linting Firefox with this PR took 9.23s vs 9.37s on main (1% faster)
📖 Linting Kickstarter with this PR took 8.11s vs 8.1s on main (0% slower)
📖 Linting Moya with this PR took 0.49s vs 0.49s on main (0% slower)
📖 Linting NetNewsWire with this PR took 2.41s vs 2.36s on main (2% slower)
📖 Linting Nimble with this PR took 0.69s vs 0.69s on main (0% slower)
📖 Linting PocketCasts with this PR took 6.84s vs 6.86s on main (0% faster)
📖 Linting Quick with this PR took 0.34s vs 0.34s on main (0% slower)
📖 Linting Realm with this PR took 4.02s vs 3.97s on main (1% slower)
📖 Linting Sourcery with this PR took 2.1s vs 2.12s on main (0% faster)
📖 Linting Swift with this PR took 3.91s vs 3.96s on main (1% faster)
📖 Linting VLC with this PR took 1.09s vs 1.14s on main (4% faster)
📖 Linting Wire with this PR took 14.25s vs 14.28s on main (0% faster)
📖 Linting WordPress with this PR took 9.78s vs 9.75s on main (0% slower)

Generated by 🚫 Danger

@SimplyDanny SimplyDanny enabled auto-merge (squash) May 11, 2024 10:12
@SimplyDanny SimplyDanny merged commit c29391a into realm:main May 11, 2024
12 checks passed
@SimplyDanny SimplyDanny deleted the report-invalid-keys branch May 11, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There is a problem with allowed_symbols rule configuration after updating to 0.54.0
2 participants