Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect configuration in unneeded_override rule's rewriter #5579

Merged
merged 1 commit into from
May 15, 2024

Conversation

SimplyDanny
Copy link
Collaborator

Fixes #5571.

@SimplyDanny SimplyDanny enabled auto-merge (squash) May 15, 2024 17:47
@SwiftLintBot
Copy link

17 Messages
📖 Linting Aerial with this PR took 1.25s vs 1.26s on main (0% faster)
📖 Linting Alamofire with this PR took 1.79s vs 1.84s on main (2% faster)
📖 Linting Brave with this PR took 10.51s vs 10.47s on main (0% slower)
📖 Linting DuckDuckGo with this PR took 5.52s vs 5.55s on main (0% faster)
📖 Linting Firefox with this PR took 13.74s vs 13.79s on main (0% faster)
📖 Linting Kickstarter with this PR took 12.75s vs 12.81s on main (0% faster)
📖 Linting Moya with this PR took 0.7s vs 0.7s on main (0% slower)
📖 Linting NetNewsWire with this PR took 3.72s vs 3.73s on main (0% faster)
📖 Linting Nimble with this PR took 1.03s vs 1.03s on main (0% slower)
📖 Linting PocketCasts with this PR took 10.42s vs 10.46s on main (0% faster)
📖 Linting Quick with this PR took 0.57s vs 0.54s on main (5% slower)
📖 Linting Realm with this PR took 6.36s vs 6.4s on main (0% faster)
📖 Linting Sourcery with this PR took 3.17s vs 3.22s on main (1% faster)
📖 Linting Swift with this PR took 6.37s vs 6.37s on main (0% slower)
📖 Linting VLC with this PR took 1.68s vs 1.7s on main (1% faster)
📖 Linting Wire with this PR took 23.83s vs 23.98s on main (0% faster)
📖 Linting WordPress with this PR took 15.88s vs 15.94s on main (0% faster)

Generated by 🚫 Danger

@SimplyDanny SimplyDanny merged commit 40bee88 into realm:main May 15, 2024
12 checks passed
@SimplyDanny SimplyDanny deleted the respect-option-in-rewriter branch May 15, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unneeded_override breaks fixes for "Automatic Initializer Inheritance"
2 participants