Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated path argument #5614

Merged

Conversation

mildm8nnered
Copy link
Collaborator

@mildm8nnered mildm8nnered commented Jun 3, 2024

Removes the deprecated path argument.

Added this as a breaking change to the changelog, as I think it may be in some cases. For example

https://github.com/fastlane/fastlane/blob/806c80c39754034c3dfcdade6beb51bb55c7f3b1/fastlane/spec/actions_specs/swiftlint_spec.rb#L126

@mildm8nnered mildm8nnered changed the title Mildm8nnered remove deprecated path argument Remove deprecated path argument Jun 3, 2024
@mildm8nnered mildm8nnered marked this pull request as ready for review June 3, 2024 22:38
Source/swiftlint/Commands/Analyze.swift Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Source/swiftlint/Commands/Lint.swift Outdated Show resolved Hide resolved
@SimplyDanny SimplyDanny force-pushed the mildm8nnered-remove-deprecated-path-argument branch from e42d6dd to 9269fe5 Compare June 22, 2024 07:19
@SimplyDanny SimplyDanny enabled auto-merge (squash) June 22, 2024 07:19
@SwiftLintBot
Copy link

17 Messages
📖 Linting Aerial with this PR took 0.84s vs 0.81s on main (3% slower)
📖 Linting Alamofire with this PR took 1.17s vs 1.14s on main (2% slower)
📖 Linting Brave with this PR took 6.62s vs 6.73s on main (1% faster)
📖 Linting DuckDuckGo with this PR took 3.5s vs 3.46s on main (1% slower)
📖 Linting Firefox with this PR took 9.56s vs 9.52s on main (0% slower)
📖 Linting Kickstarter with this PR took 8.1s vs 8.2s on main (1% faster)
📖 Linting Moya with this PR took 0.5s vs 0.48s on main (4% slower)
📖 Linting NetNewsWire with this PR took 2.32s vs 2.32s on main (0% slower)
📖 Linting Nimble with this PR took 0.68s vs 0.71s on main (4% faster)
📖 Linting PocketCasts with this PR took 6.98s vs 7.05s on main (0% faster)
📖 Linting Quick with this PR took 0.39s vs 0.38s on main (2% slower)
📖 Linting Realm with this PR took 4.08s vs 4.15s on main (1% faster)
📖 Linting Sourcery with this PR took 2.22s vs 2.09s on main (6% slower)
📖 Linting Swift with this PR took 3.9s vs 4.03s on main (3% faster)
📖 Linting VLC with this PR took 1.12s vs 1.12s on main (0% slower)
📖 Linting Wire with this PR took 14.8s vs 14.78s on main (0% slower)
📖 Linting WordPress with this PR took 11.55s vs 11.44s on main (0% slower)

Generated by 🚫 Danger

@SimplyDanny SimplyDanny merged commit 47ef99c into realm:main Jun 22, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants