-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated path argument #5614
Merged
SimplyDanny
merged 12 commits into
realm:main
from
mildm8nnered:mildm8nnered-remove-deprecated-path-argument
Jun 22, 2024
Merged
Remove deprecated path argument #5614
SimplyDanny
merged 12 commits into
realm:main
from
mildm8nnered:mildm8nnered-remove-deprecated-path-argument
Jun 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mildm8nnered
changed the title
Mildm8nnered remove deprecated path argument
Remove deprecated path argument
Jun 3, 2024
SimplyDanny
reviewed
Jun 4, 2024
SimplyDanny
approved these changes
Jun 8, 2024
Co-authored-by: Danny Mösch <danny.moesch@icloud.com>
SimplyDanny
force-pushed
the
mildm8nnered-remove-deprecated-path-argument
branch
from
June 22, 2024 07:19
e42d6dd
to
9269fe5
Compare
Generated by 🚫 Danger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the deprecated path argument.
Added this as a breaking change to the changelog, as I think it may be in some cases. For example
https://github.com/fastlane/fastlane/blob/806c80c39754034c3dfcdade6beb51bb55c7f3b1/fastlane/spec/actions_specs/swiftlint_spec.rb#L126